You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2023/02/28 14:22:02 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #24388: Remove Hint DistSQL.
yx9o opened a new pull request, #24388:
URL: https://github.com/apache/shardingsphere/pull/24388
For #23953.
Changes proposed in this pull request:
- Remove test
- Remove g4
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24388: Remove Hint DistSQL.
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24388:
URL: https://github.com/apache/shardingsphere/pull/24388#discussion_r1121049758
##########
features/sharding/distsql/parser/src/main/antlr4/imports/sharding/Keyword.g4:
##########
@@ -119,30 +119,10 @@ HINT
: H I N T
;
-SET
- : S E T
- ;
-
-ADD
- : A D D
- ;
-
-DATABASE_VALUE
- : D A T A B A S E UL_ V A L U E
- ;
-
TABLE_VALUE
Review Comment:
Hi @yx9o
Why does TABLE_VALUE need to be preserved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on a diff in pull request #24388: Remove Hint DistSQL.
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on code in PR #24388:
URL: https://github.com/apache/shardingsphere/pull/24388#discussion_r1121119079
##########
features/sharding/distsql/parser/src/main/antlr4/imports/sharding/Keyword.g4:
##########
@@ -119,30 +119,10 @@ HINT
: H I N T
;
-SET
- : S E T
- ;
-
-ADD
- : A D D
- ;
-
-DATABASE_VALUE
- : D A T A B A S E UL_ V A L U E
- ;
-
TABLE_VALUE
Review Comment:
Ok, probably missed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24388: Remove Hint DistSQL.
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24388:
URL: https://github.com/apache/shardingsphere/pull/24388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org