[GitHub] [accumulo] Manno15 commented on a change in pull request #1944: Closes #1929. Add property verification for Sampler Options

[GitBox <gi...@apache.org>]

Manno15 commented on a change in pull request #1944:
URL: https://github.com/apache/accumulo/pull/1944#discussion_r580353529



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1352,6 +1352,17 @@ public static boolean isValidZooPropertyKey(String key) {
         || key.startsWith(REPLICATION_PREFIX.getKey());
   }
 
+  /**
+   * Checks if the given sampler option is valid
+   *
+   * @param option
+   *          property option
+   * @return true if option is a valid sampler option
+   */
+  public static boolean isValidSamplerOption(String option) {
+    return option.endsWith("hasher") || option.endsWith("modules");
+  }
+

Review comment:
       That is what I was afraid of. Guess there isn't an easy way to guarantee validity. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org