You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/02 07:54:15 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4564: Move scaling http codes from core to bootstrap.

KomachiSion opened a new pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564
 
 
   For #4510 .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#discussion_r386256739
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-bootstrap/src/test/resources/META-INF/services/org.apache.shardingsphere.shardingscaling.core.spi.ScalingEntry
 ##########
 @@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+org.apache.shardingsphere.shardingscaling.fixture.FixtureH2ScalingEntry
 
 Review comment:
   Blank line at end of file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
KomachiSion commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#discussion_r386257277
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-bootstrap/src/test/resources/META-INF/services/org.apache.shardingsphere.shardingscaling.core.spi.ScalingEntry
 ##########
 @@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+org.apache.shardingsphere.shardingscaling.fixture.FixtureH2ScalingEntry
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#discussion_r386251725
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-bootstrap/src/test/resources/META-INF/services/org.apache.shardingsphere.shardingscaling.core.spi.ScalingEntry
 ##########
 @@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 
 Review comment:
   Copyright error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#issuecomment-593278405
 
 
   ## Pull Request Test Coverage Report for [Build 9955](https://coveralls.io/builds/29066270)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **63** unchanged lines in **11** files lost coverage.
   * Overall coverage decreased (**-0.3%**) to **59.698%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/Bootstrap.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2FBootstrap.java#L44) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/utils/RuntimeUtil.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Futils%2FRuntimeUtil.java#L25) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/ShardingScalingJob.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2FShardingScalingJob.java#L38) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/exception/ScalingJobNotFoundException.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexception%2FScalingJobNotFoundException.java#L26) | 2 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/checker/CheckerFactory.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchecker%2FCheckerFactory.java#L37) | 2 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/DefaultSyncTaskFactory.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2FDefaultSyncTaskFactory.java#L33) | 2 | 50.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/position/LogPositionManagerFactory.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fposition%2FLogPositionManagerFactory.java#L38) | 3 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskControlStatus.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskControlStatus.java#L26) | 8 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/realtime/RealtimeDataSyncTask.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Frealtime%2FRealtimeDataSyncTask.java#L46) | 11 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskController.java](https://coveralls.io/builds/29066270/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskController.java#L36) | 15 | 0% |
   <!-- | **Total:** | **63** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29066270/badge)](https://coveralls.io/builds/29066270) |
   | :-- | --: |
   | Change from base [Build 9932](https://coveralls.io/builds/29063047): |  -0.3% |
   | Covered Lines: | 12499 |
   | Relevant Lines: | 20937 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
KomachiSion commented on a change in pull request #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#discussion_r386257389
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-bootstrap/src/test/resources/META-INF/services/org.apache.shardingsphere.shardingscaling.core.spi.ScalingEntry
 ##########
 @@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4564: Move scaling http codes from core to bootstrap.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4564: Move scaling http codes from core to bootstrap.
URL: https://github.com/apache/incubator-shardingsphere/pull/4564#issuecomment-593278405
 
 
   ## Pull Request Test Coverage Report for [Build 9959](https://coveralls.io/builds/29067631)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **63** unchanged lines in **11** files lost coverage.
   * Overall coverage decreased (**-0.3%**) to **59.698%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/Bootstrap.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2FBootstrap.java#L44) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/utils/RuntimeUtil.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Futils%2FRuntimeUtil.java#L25) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/ShardingScalingJob.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2FShardingScalingJob.java#L38) | 1 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/exception/ScalingJobNotFoundException.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexception%2FScalingJobNotFoundException.java#L26) | 2 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/checker/CheckerFactory.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchecker%2FCheckerFactory.java#L37) | 2 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/DefaultSyncTaskFactory.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2FDefaultSyncTaskFactory.java#L33) | 2 | 50.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/position/LogPositionManagerFactory.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fposition%2FLogPositionManagerFactory.java#L38) | 3 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskControlStatus.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskControlStatus.java#L26) | 8 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/realtime/RealtimeDataSyncTask.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Frealtime%2FRealtimeDataSyncTask.java#L46) | 11 | 0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskController.java](https://coveralls.io/builds/29067631/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskController.java#L36) | 15 | 0% |
   <!-- | **Total:** | **63** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29067631/badge)](https://coveralls.io/builds/29067631) |
   | :-- | --: |
   | Change from base [Build 9932](https://coveralls.io/builds/29063047): |  -0.3% |
   | Covered Lines: | 12499 |
   | Relevant Lines: | 20937 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services