[GitHub] [incubator-pekko] Claudenw commented on a diff in pull request #52: require PR reviews and linear history

[GitBox <gi...@apache.org>]

Claudenw commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko/pull/52#discussion_r1025260449


##########
.asf.yaml:
##########
@@ -28,7 +28,21 @@ github:
     rebase:  true
 
   protected_branches:
-    main: { }
+    main:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Scalafmt
+  
+      required_pull_request_reviews:
+        dismiss_stale_reviews: false
+        require_code_owner_reviews: false
+        required_approving_review_count: 1

Review Comment:
   I was looking for a couple of things to be addressed:
   
   1. At least one review
   2. Any review that has open requests or discussion blocks the merge. (only merge when consensus is reached).
   
   I don't have an opinion on scalafmt in particular, but I believe that there should be checks for formatting in general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org