You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/13 11:23:39 UTC
[GitHub] [lucene] mocobeta opened a new pull request, #811: Add some basic tasks to help/workflow
mocobeta opened a new pull request, #811:
URL: https://github.com/apache/lucene/pull/811
They might be worth adding to `help/workflow.txt`, and to me, it'd be great if we make this file a single entry point for every developer. e.g., we can just add a link to it from https://github.com/apache/lucene/blob/main/CONTRIBUTING.md instead of explaining each grade command to readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850322876
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
> This is a general question on where to explain how gradle works (-p command) and whether this document should provide ready-to-use commands doing things or an explanation how to assemble those commands from scratch.
To me, a list of ready-to-use commands would be sufficient for this help document; here I'd give priority to brevity over detailed explanations. The usage of `-p` would be easily inferred from the examples, and I think developers who need more information about Gradle can always refer to the Gradle's documentation or other resources (just as I do).
Maybe I'm not the right person to give an opinion on documentation for beginners... but I guess readers of this guide are experienced Java developers anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1100018613
@gautamworah96 thanks for your comments.
> I sometimes use the -Ptests.iters=<some_large_num> param for beasting out multiple runs of a single test to catch random edge cases that I might have missed (this was another trick that I just stumbled upon through JIRA). Maybe we could add this to the workflow file as well?
I found `help/tests.txt` (the source for `gradlew helpTests` task) has a dedicated section about "Reiteration", where `-Ptests.iters` option is explained.
https://github.com/apache/lucene/blob/main/help/tests.txt#L87
`test` task has many parameters, I think it'd be better to encourage devs to refer to that file than augment `workflow.txt`? (You can see a pointer says `run "gradlew :helpTests" for more` in L12 in workflow.txt.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850154058
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
I copied these lines then modified it:
https://github.com/apache/lucene/blob/9b96a05f50a42f2a4c46fccbadd3057ba9b22933/help/workflow.txt#L24-L25
If "JAR" is too specific, how about "artifacts"?
```
Assemble all Lucene artifacts (JARs, and so on).
gradlew assemble
```
Gradle's documentation says "Translates Assembly language source files into object files." This would be correct but too general to me...
https://docs.gradle.org/current/dsl/org.gradle.language.assembler.tasks.Assemble.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r851181043
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
```suggestion
Assemble all Lucene artifacts (JARs, and so on):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta merged PR #811:
URL: https://github.com/apache/lucene/pull/811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850334643
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
> Separately - do you ever assemble javadocs for a single module? What's the point of doing that?
Yes, sometimes - to see the changes on javadocs are fine in HTML (and it is convenient for linting in my usage). I added this line mainly for developers who want to contribute documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850322876
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
> This is a general question on where to explain how gradle works (-p command) and whether this document should provide ready-to-use commands doing things or an explanation how to assemble those commands from scratch.
To me, a list of ready-to-use commands would be sufficient for this help document; here I'd give priority to brevity over detailed explanations. The usage of `-p` would be easily inferred from the examples, and I think developers who need more information about Gradle can always refer to the Gradle's documentation or other resources (just as I do).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r851184763
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
Updated in https://github.com/apache/lucene/pull/811/commits/9c41951601d2b07deae84e8700c7342385141754. I didn't touch the existing description for the same command with `-p`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850758533
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1099803914
I don't have any comments on this PR but a general +1 on the effort. I've sometimes found myself stumbling around the package searching for gradle commands that do what I want to do. Having a single file with some ready to use commands sounds perfect. I would also give a +1 for directly linking it from CONTRIBUTING.md. The easier we make it for contributors the better!
I sometimes also use the `-Ptests.iters=<some_large_num>` param for beasting out multiple runs of a single test to catch easy edge cases that I might have missed (this was another trick that I just stumbled upon through JIRA). Maybe we could add this to the workflow file as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1100945965
Please, go ahead, @mocobeta. I'm on Easter holidays and with intermittent access to the internet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1097940536
@dweiss would you mind taking a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r849753568
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
This is a general question on where to explain how gradle works (-p command) and whether this document should provide ready-to-use commands doing things or an explanation how to assemble those commands from scratch. I'm not sure how much people are willing to read about gradle... :)
Separately - do you ever assemble javadocs for a single module? What's the point of doing that?
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
This convention task is for assembling... well, things that need to be assembled. It's not just JARs but typically also other stuff (say, the documentation could be assembled from sources). I'm not sure if it makes a difference but perhaps it's worth clarifying here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1100650074
@dweiss would you mind if I push it to main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850154058
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
I copied these lines then modified it:
https://github.com/apache/lucene/blob/9b96a05f50a42f2a4c46fccbadd3057ba9b22933/help/workflow.txt#L24-L25
If "JAR" is too specific, how about "artifacts"?
```
Assemble all Lucene artifacts (JARs, and so on).
gradlew assemble
```
~Gradle's documentation says "Translates Assembly language source files into object files." This would be correct but too general to me...~
~https://docs.gradle.org/current/dsl/org.gradle.language.assembler.tasks.Assemble.html~
Correction: this doc looks like about literally assembly language, not the convention task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1100574008
> I think we can still do some more to help new contributors but I have no specific action items in my head. I'll create separate JIRAs/PRs if I come up with something.
Sounds great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850758274
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
ok, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850154058
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
I copied these lines then modified it:
https://github.com/apache/lucene/blob/9b96a05f50a42f2a4c46fccbadd3057ba9b22933/help/workflow.txt#L24-L25
If "JAR" is too specific, how about "artifacts"?
```
Assemble all Lucene artifacts (JARs, and so on).
gradlew assemble
```
~Gradle's documentation says "Translates Assembly language source files into object files." This would be correct but too general to me...~
~https://docs.gradle.org/current/dsl/org.gradle.language.assembler.tasks.Assemble.html~
Correction: this doc looks like about literally assembly language (I didn't know gradle support assembly...), not the convention task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1100391643
Hmm. I had not looked at the `help/tests.txt` file. +1 on not adding all the comprehensive options to this workflow file.
LGTM overall.
I think we can still do some more to help new contributors but I have no specific action items in my head. I'll create separate JIRAs/PRs if I come up with something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r850334643
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
> Separately - do you ever assemble javadocs for a single module? What's the point of doing that?
Yes, sometimes - to see the changes on javadocs are fine in HTML (and it is convenient for lining in my usage). I added this line mainly for developers who want to contribute documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #811:
URL: https://github.com/apache/lucene/pull/811#issuecomment-1101035368
Thanks and apologies for interrupting your holidays, I'll merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org