You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "DongyuanPan (via GitHub)" <gi...@apache.org> on 2023/05/23 09:20:00 UTC
[GitHub] [rocketmq] DongyuanPan opened a new pull request, #6798: [ISSUE #6795]Support batch ack when reput buffer ak to store in PopBufferMergeService
DongyuanPan opened a new pull request, #6798:
URL: https://github.com/apache/rocketmq/pull/6798
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6795
### Brief Description
see ISSUE #6795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6798: [ISSUE #6797]Support batch ack when reput buffer ak to store in PopBufferMergeService
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6798:
URL: https://github.com/apache/rocketmq/pull/6798#issuecomment-1560369684
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6798](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aad1f61) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/c5fec3af414f029759cc9ec498c425ce6ad37612?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c5fec3a) will **decrease** coverage by `0.22%`.
> The diff coverage is `43.84%`.
```diff
@@ Coverage Diff @@
## develop #6798 +/- ##
=============================================
- Coverage 43.08% 42.86% -0.22%
- Complexity 8920 8984 +64
=============================================
Files 1105 1105
Lines 78002 78471 +469
Branches 10151 10227 +76
=============================================
+ Hits 33604 33638 +34
- Misses 40180 40615 +435
Partials 4218 4218
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/common/ControllerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQ29udHJvbGxlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/rocketmq/common/PopAckConstants.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vUG9wQWNrQ29uc3RhbnRzLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../impl/heartbeat/DefaultBrokerHeartbeatManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL2hlYXJ0YmVhdC9EZWZhdWx0QnJva2VySGVhcnRiZWF0TWFuYWdlci5qYXZh) | `82.27% <ø> (ø)` | |
| [...cketmq/broker/processor/PopBufferMergeService.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcEJ1ZmZlck1lcmdlU2VydmljZS5qYXZh) | `30.29% <1.92%> (-3.04%)` | :arrow_down: |
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `27.97% <25.00%> (+0.01%)` | :arrow_up: |
| [...ava/org/apache/rocketmq/store/pop/BatchAckMsg.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3BvcC9CYXRjaEFja01zZy5qYXZh) | `33.33% <33.33%> (ø)` | |
| [...he/rocketmq/broker/processor/PopReviveService.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==) | `36.47% <35.48%> (-1.70%)` | :arrow_down: |
| [...tmq/controller/impl/manager/BrokerReplicaInfo.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvQnJva2VyUmVwbGljYUluZm8uamF2YQ==) | `61.11% <45.45%> (-9.86%)` | :arrow_down: |
| [.../apache/rocketmq/controller/ControllerManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9Db250cm9sbGVyTWFuYWdlci5qYXZh) | `49.66% <53.84%> (+1.46%)` | :arrow_up: |
| [...he/rocketmq/controller/impl/DLedgerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RMZWRnZXJDb250cm9sbGVyLmphdmE=) | `71.68% <79.31%> (+5.02%)` | :arrow_up: |
| ... and [3 more](https://app.codecov.io/gh/apache/rocketmq/pull/6798?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6798/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing merged pull request #6798: [ISSUE #6797]Support batch ack when reput buffer ak to store in PopBufferMergeService
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #6798:
URL: https://github.com/apache/rocketmq/pull/6798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #6798: [ISSUE #6797]Support batch ack when reput buffer ak to store in PopBufferMergeService
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #6798:
URL: https://github.com/apache/rocketmq/pull/6798#issuecomment-1560379952
LGTM～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org