You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/11/18 15:48:51 UTC

[GitHub] [activemq-artemis] jbertram commented on issue #2895: ARTEMIS-2550 Websocket Continuation Frame Support

jbertram commented on issue #2895: ARTEMIS-2550 Websocket Continuation Frame Support
URL: https://github.com/apache/activemq-artemis/pull/2895#issuecomment-555075479
 
 
   This looks good. The only change I'd recommend is renaming `WebSocketContinuationFrameEncoder` to something more generic since it handles both normal binary frames as well as continuation frames. Perhaps just `WebSocketFrameEncoder` would be best.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services