[GitHub] [iceberg] rdblue commented on a change in pull request #1818: Flink: Add RowDataTaskWriter to accept equality deletions.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1818:
URL: https://github.com/apache/iceberg/pull/1818#discussion_r529984488



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -64,22 +66,25 @@ public static TableMetadata newTableMetadata(TableOperations ops,
                                                PartitionSpec spec,
                                                String location,
                                                Map<String, String> properties) {
-    return newTableMetadata(schema, spec, SortOrder.unsorted(), location, properties, DEFAULT_TABLE_FORMAT_VERSION);
+    int formatVersion = PropertyUtil.propertyAsInt(properties, FORMAT_VERSION, FORMAT_VERSION_DEFAULT);
+    return newTableMetadata(schema, spec, SortOrder.unsorted(), location, properties, formatVersion);

Review comment:
       Right now, we don't make it easy to create a v2 table because we don't want people actually using them. That's why all of the tests currently create a table and then update it to v2.
   
   We would also need to remove `FORMAT_VERSION` from properties because we don't intend to keep a table property in sync with the table version in metadata.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org