You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2025/12/29 07:39:17 UTC

[PR] move stats depend rbo rules after rewrite-cte-children [doris]

englefly opened a new pull request, #59444:
URL: https://github.com/apache/doris/pull/59444

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695893739

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 35424 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 350d892ff1272ca9dfb15eb0248f69309a8eac29, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17627	4219	4042	4042
   q2	2024	349	231	231
   q3	10208	1294	729	729
   q4	10231	962	343	343
   q5	7572	2139	1909	1909
   q6	196	168	135	135
   q7	954	801	658	658
   q8	9270	1449	1133	1133
   q9	7009	5155	5171	5155
   q10	6848	1847	1452	1452
   q11	507	305	293	293
   q12	726	735	576	576
   q13	17801	3822	3066	3066
   q14	299	289	276	276
   q15	578	504	502	502
   q16	706	673	603	603
   q17	718	742	632	632
   q18	7595	7648	7849	7648
   q19	1605	1020	631	631
   q20	427	408	255	255
   q21	4591	4146	4068	4068
   q22	1184	1142	1087	1087
   Total cold run time: 108676 ms
   Total hot run time: 35424 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4412	4274	4327	4274
   q2	333	403	312	312
   q3	2253	3151	2391	2391
   q4	1408	1827	1497	1497
   q5	4486	4328	4329	4328
   q6	213	172	125	125
   q7	2109	2062	1731	1731
   q8	2501	2336	2249	2249
   q9	7463	7059	7113	7059
   q10	2270	2548	2110	2110
   q11	544	460	435	435
   q12	674	684	604	604
   q13	3313	3784	3034	3034
   q14	265	289	251	251
   q15	523	485	470	470
   q16	628	655	603	603
   q17	1104	1244	1320	1244
   q18	7373	7423	7286	7286
   q19	875	840	858	840
   q20	1890	1952	1799	1799
   q21	4522	4254	4132	4132
   q22	1102	1019	1015	1015
   Total cold run time: 50261 ms
   Total hot run time: 47789 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695916982

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174540 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 350d892ff1272ca9dfb15eb0248f69309a8eac29, data reload: false
   
   query5	4423	620	479	479
   query6	358	240	223	223
   query7	4221	481	268	268
   query8	348	251	231	231
   query9	8774	2595	2599	2595
   query10	547	386	332	332
   query11	15269	15096	14883	14883
   query12	172	119	117	117
   query13	1266	522	418	418
   query14	6391	3019	2774	2774
   query14_1	2645	2603	2628	2603
   query15	202	193	175	175
   query16	991	491	456	456
   query17	1114	704	600	600
   query18	2673	443	348	348
   query19	228	226	201	201
   query20	130	127	117	117
   query21	222	159	124	124
   query22	3940	3960	3895	3895
   query23	16107	15714	15289	15289
   query23_1	15475	15544	15521	15521
   query24	7415	1607	1204	1204
   query24_1	1212	1196	1198	1196
   query25	565	474	429	429
   query26	1256	265	165	165
   query27	2762	457	298	298
   query28	4518	2174	2152	2152
   query29	806	616	430	430
   query30	308	234	207	207
   query31	808	591	562	562
   query32	75	72	63	63
   query33	528	339	289	289
   query34	886	894	514	514
   query35	732	808	705	705
   query36	870	892	761	761
   query37	140	96	80	80
   query38	2691	2640	2655	2640
   query39	771	743	719	719
   query39_1	724	702	720	702
   query40	217	135	120	120
   query41	69	62	61	61
   query42	101	101	103	101
   query43	435	459	404	404
   query44	1338	748	755	748
   query45	195	181	176	176
   query46	865	958	604	604
   query47	1390	1391	1363	1363
   query48	315	336	243	243
   query49	606	428	333	333
   query50	641	275	203	203
   query51	3763	3803	3771	3771
   query52	98	108	92	92
   query53	295	324	283	283
   query54	298	254	253	253
   query55	73	74	74	74
   query56	290	297	285	285
   query57	1022	1009	916	916
   query58	259	269	253	253
   query59	2129	2163	2031	2031
   query60	355	312	299	299
   query61	161	183	157	157
   query62	399	375	337	337
   query63	298	265	259	259
   query64	4864	1325	1011	1011
   query65	3804	3737	3723	3723
   query66	1377	420	317	317
   query67	15287	15541	14996	14996
   query68	8224	1000	715	715
   query69	504	347	305	305
   query70	1006	969	823	823
   query71	373	302	283	283
   query72	6192	4838	4931	4838
   query73	684	607	309	309
   query74	8828	8825	8574	8574
   query75	2909	2878	2528	2528
   query76	3914	1076	669	669
   query77	512	353	273	273
   query78	9819	9983	9136	9136
   query79	1491	914	604	604
   query80	671	584	501	501
   query81	499	265	237	237
   query82	217	144	112	112
   query83	264	256	238	238
   query84	257	121	103	103
   query85	890	522	476	476
   query86	336	321	291	291
   query87	2855	2833	2785	2785
   query88	3226	2316	2349	2316
   query89	398	352	313	313
   query90	1964	154	148	148
   query91	177	176	150	150
   query92	67	68	65	65
   query93	1033	927	563	563
   query94	567	330	281	281
   query95	576	322	367	322
   query96	599	467	211	211
   query97	2292	2377	2279	2279
   query98	222	195	196	195
   query99	573	590	524	524
   Total cold run time: 254582 ms
   Total hot run time: 174540 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695799969

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/350d892ff1272ca9dfb15eb0248f69309a8eac29_350d892ff1272ca9dfb15eb0248f69309a8eac29_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/350d892ff1272ca9dfb15eb0248f69309a8eac29_350d892ff1272ca9dfb15eb0248f69309a8eac29_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.52% (1771/2227) |
   | Line Coverage     | 64.84% (31316/48299) |
   | Region Coverage   | 65.37% (15579/23831) |
   | Branch Coverage   | 55.99% (8284/14796) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3696200427

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/350d892ff1272ca9dfb15eb0248f69309a8eac29_350d892ff1272ca9dfb15eb0248f69309a8eac29/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/350d892ff1272ca9dfb15eb0248f69309a8eac29_350d892ff1272ca9dfb15eb0248f69309a8eac29/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.39% (18950/35496) |
   | Line Coverage     | 39.26% (175763/447695) |
   | Region Coverage   | 33.84% (136078/402141) |
   | Branch Coverage   | 34.75% (58713/168971) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695740603

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly closed pull request #59444: move stats depend rbo rules after rewrite-cte-children
URL: https://github.com/apache/doris/pull/59444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695740712

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3696337346

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (13/13)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59444_350d892ff1272ca9dfb15eb0248f69309a8eac29_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59444_350d892ff1272ca9dfb15eb0248f69309a8eac29_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] move stats depend rbo rules after rewrite-cte-children [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59444:
URL: https://github.com/apache/doris/pull/59444#issuecomment-3695928725

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 26.92 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 350d892ff1272ca9dfb15eb0248f69309a8eac29, data reload: false
   
   query1	0.05	0.05	0.05
   query2	0.10	0.05	0.05
   query3	0.25	0.09	0.09
   query4	1.61	0.12	0.11
   query5	0.27	0.26	0.26
   query6	1.16	0.67	0.65
   query7	0.03	0.03	0.03
   query8	0.06	0.04	0.05
   query9	0.56	0.48	0.48
   query10	0.56	0.54	0.54
   query11	0.15	0.11	0.11
   query12	0.16	0.12	0.13
   query13	0.62	0.60	0.60
   query14	1.00	0.98	0.98
   query15	0.80	0.78	0.79
   query16	0.39	0.40	0.39
   query17	1.06	1.06	1.03
   query18	0.23	0.22	0.21
   query19	1.90	1.82	1.89
   query20	0.02	0.01	0.01
   query21	15.45	0.28	0.14
   query22	5.00	0.04	0.05
   query23	16.04	0.29	0.11
   query24	1.04	0.24	0.47
   query25	0.12	0.11	0.06
   query26	0.14	0.14	0.15
   query27	0.06	0.05	0.05
   query28	4.00	1.04	0.88
   query29	12.60	3.94	3.16
   query30	0.27	0.15	0.11
   query31	2.81	0.62	0.37
   query32	3.22	0.55	0.47
   query33	2.94	3.00	3.09
   query34	16.71	5.08	4.49
   query35	4.50	4.46	4.47
   query36	0.68	0.50	0.50
   query37	0.10	0.06	0.07
   query38	0.07	0.04	0.03
   query39	0.04	0.03	0.03
   query40	0.16	0.13	0.14
   query41	0.09	0.04	0.03
   query42	0.05	0.03	0.03
   query43	0.04	0.04	0.04
   Total cold run time: 97.11 s
   Total hot run time: 26.92 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org