You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/22 12:55:58 UTC

[jira] [Commented] (BEAM-799) Support GroupByKey directly

    [ https://issues.apache.org/jira/browse/BEAM-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597813#comment-15597813 ] 

ASF GitHub Bot commented on BEAM-799:
-------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/incubator-beam/pull/1162

    [BEAM-799] Support GroupByKey directly

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/incubator-beam BEAM-799

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1162
    
----
commit 52ed2eb3fee7e3af166f015851845fc4ff9f57e9
Author: Sela <an...@paypal.com>
Date:   2016-10-22T11:51:50Z

    Remove runner override for GroupByKey.
    
    [BEAM-799] Support GroupByKey directly.

commit 93eaf607c26585e5157eb17812025df41bbd5072
Author: Sela <an...@paypal.com>
Date:   2016-10-22T12:44:32Z

    Avoid NPE if no sideInputs are available in reader.

commit 62c7f0e30a0246cc835f46e75046c72be14a1ba1
Author: Sela <an...@paypal.com>
Date:   2016-10-22T12:45:40Z

    Handle CombineFn with or without context.

----


> Support GroupByKey directly
> ---------------------------
>
>                 Key: BEAM-799
>                 URL: https://issues.apache.org/jira/browse/BEAM-799
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> Currently the SparkRunner supports GroupByKey via override with GroupByKeyViaGroupByKeyOnly, make it support GroupByKey directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)