You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2023/08/15 08:40:09 UTC
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20358
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two forms to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts form, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections form, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Note that these three items of information: "User", "Delegated User"
and "Network Address" from the Sessions form have been moved to the
Connections form.
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
8 files changed, 258 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/1
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13824/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 10:38:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#3).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two forms to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts form, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections form, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Note that these three items of information: "User", "Delegated User"
and "Network Address" from the Sessions form have been moved to the
Connections form.
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
8 files changed, 266 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/3
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#5).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/5
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/20358/7/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/20358/7/be/src/service/impala-http-handler.cc@693
PS7, Line 693: Document* document) {
Let's hold session_state_map_lock_ and connection_to_sessions_map_lock_ in this method so we won't see inconsistent results between client hosts info and connections info.
session_state_map_lock_ can be acquired at the begining and connection_to_sessions_map_lock_ can be acquired after FillSessionsInfo().
http://gerrit.cloudera.org:8080/#/c/20358/7/be/src/service/impala-http-handler.cc@847
PS7, Line 847: ThriftServer::ConnectionContextList::value_type
nit: might be more clear to use the real type: shared_ptr<const ConnectionContext>
BTW, don't need to use the explictly "std::" namespace in .cc files.
http://gerrit.cloudera.org:8080/#/c/20358/7/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/7/be/src/service/impala-server.h@193
PS7, Line 193: ///
We avoid holding connection_to_sessions_map_lock_ with session_state_map_lock_ together in IMPALA-4516. But now the comment is stale. Please add a line here of:
except that when getting connections and sessions info for http requests we hold both session_state_map_lock_ and connection_to_sessions_map_lock_. It's ok since the requests finish quickly.
http://gerrit.cloudera.org:8080/#/c/20358/7/www/sessions.tmpl
File www/sessions.tmpl:
http://gerrit.cloudera.org:8080/#/c/20358/7/www/sessions.tmpl@62
PS7, Line 62: Server Name
This might be confused. What about "Connection Type" or "Type" ?
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 03:25:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/20358/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20358/3//COMMIT_MSG@9
PS3, Line 9: forms
nit: "tables"
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/rpc/thrift-server.h
File be/src/rpc/thrift-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/rpc/thrift-server.h@184
PS3, Line 184: &
nit: use pointer type for output parameters
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@694
PS3, Line 694: lock_guard<mutex> session_state_map_l(server_->session_state_map_lock_);
: lock_guard<mutex> connection_to_sessions_map_l(
: server_->connection_to_sessions_map_lock_);
: lock_guard<mutex> client_hostname_to_connections_map_l(
: server_->client_hostname_to_connections_map_lock_);
I'm not sure whether acquiring them together has the risk of dead locks. The "Locking" section in the class comment of ImpalaServer mentions that 'connection_to_sessions_map_lock_' is not held in conjunction with other locks.
It's not guarenteed that the contents of these maps are consistent (I think it's a bug). E.g. we do update them in separated lock protections:
https://github.com/apache/impala/blob/a34f7ce63299c72ef45a99b01bb4e80210befbff/be/src/service/impala-server.cc#L2598-L2608
I don't see other codes holding these locks together so maybe it's ok. Let's at least update the class comment of ImpalaServer about the lock holding order.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@807
PS3, Line 807: client_hostname_to_connections_map_
This map is only used here. Can we construct it using the ConnectionContextList we get in step2 ? If so, we don't need to maintain it with a new lock.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@829
PS3, Line 829: ++total_sessions;
A session can be used in multiple connections. This seems to over-count the total sessions.
Same for other counters like total_inactive_sessions, total_active_sessions, inflight_queries, total_queries.
I think we should deduplicate the sessions across connections, and then do the counting.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@857
PS3, Line 857: }
This method is too long now. Let's extract the 3 parts into 3 methods to make it simpler.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.h@192
PS3, Line 192: /// * connection_to_sessions_map_lock_
Please mention 'client_hostname_to_connections_map_lock_' in this section.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@2619
PS3, Line 2619: .insert(connection_context.connection_id);
Why do we insert it twice? One at the begining and one here.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@3454
PS3, Line 3454: ThriftServer::ConnectionContextList
Instead of constructing a vector and copying it out, let's pass in a pointer and modify it here.
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@3456
PS3, Line 3456:
nit: change double spaces to single space. Same for the following comments.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Aug 2023 06:51:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 5:
Yes, this ambiguity should be avoided.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 09:48:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/20358/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20358/3//COMMIT_MSG@9
PS3, Line 9: forms
> nit: "tables"
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/rpc/thrift-server.h
File be/src/rpc/thrift-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/rpc/thrift-server.h@184
PS3, Line 184: &
> nit: use pointer type for output parameters
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@694
PS3, Line 694: lock_guard<mutex> session_state_map_l(server_->session_state_map_lock_);
: lock_guard<mutex> connection_to_sessions_map_l(
: server_->connection_to_sessions_map_lock_);
: lock_guard<mutex> client_hostname_to_connections_map_l(
: server_->client_hostname_to_connections_map_lock_);
> I'm not sure whether acquiring them together has the risk of dead locks. Th
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@807
PS3, Line 807: client_hostname_to_connections_map_
> This map is only used here. Can we construct it using the ConnectionContext
Ack
This's a good idea!
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@829
PS3, Line 829: ++total_sessions;
> A session can be used in multiple connections. This seems to over-count the
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-http-handler.cc@857
PS3, Line 857: }
> This method is too long now. Let's extract the 3 parts into 3 methods to ma
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.h@192
PS3, Line 192: /// * connection_to_sessions_map_lock_
> Please mention 'client_hostname_to_connections_map_lock_' in this section.
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@2619
PS3, Line 2619: .insert(connection_context.connection_id);
> Why do we insert it twice? One at the begining and one here.
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@3454
PS3, Line 3454: ThriftServer::ConnectionContextList
> Instead of constructing a vector and copying it out, let's pass in a pointe
Ack
http://gerrit.cloudera.org:8080/#/c/20358/3/be/src/service/impala-server.cc@3456
PS3, Line 3456:
> nit: change double spaces to single space. Same for the following comments.
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Aug 2023 11:53:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 18:34:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20358/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:
http://gerrit.cloudera.org:8080/#/c/20358/1/be/src/service/impala-http-handler.cc@843
PS1, Line 843: client_host_json.AddMember("total_connections", total_connections, document->GetAllocator());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/20358/1/be/src/service/impala-http-handler.cc@844
PS1, Line 844: client_host_json.AddMember("total_sessions", total_sessions, document->GetAllocator());
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/20358/1/be/src/service/impala-http-handler.cc@849
PS1, Line 849: client_host_json.AddMember("inflight_queries", inflight_queries, document->GetAllocator());
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 08:41:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h@525
PS4, Line 525: Merge
nit: "Merge" sounds like modifying something but we just retrieving the lists. What about keeping the old name, i.e. "GetAllConnectionContexts"?
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 08:44:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 9: Code-Review+2
LGTM. Thanks for improving the WebUI!
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:29:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9639/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:30:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13747/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 09:27:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#9).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Connection Type,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/9
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG@21
PS8, Line 21: Server Name
nit: "Connection Type"
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 07:57:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 10:55:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20358/7/www/sessions.tmpl
File www/sessions.tmpl:
http://gerrit.cloudera.org:8080/#/c/20358/7/www/sessions.tmpl@62
PS7, Line 62: Connection
> This might be confused. What about "Connection Type" or "Type" ?
Done
Naming it "Connection Type" looks good! Similar to "Session Type" in the session table.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 07:36:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9639/
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 13:47:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Connection Type,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Reviewed-on: http://gerrit.cloudera.org:8080/20358
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13744/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 09:06:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#4).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Note that these three items of information: "User", "Delegated User"
and "Network Address" from the Sessions table have been moved to the
Connections table.
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 310 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/4
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#7).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/7
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#6).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/6
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 5:
(1 comment)
> Patch Set 4: Code-Review+1
>
> (1 comment)
Yes, this ambiguity should be avoided.
http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h@525
PS4, Line 525: Merge
> nit: "Merge" sounds like modifying something but we just retrieving the lis
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 09:48:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13749/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 09:48:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13823/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 10:17:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 7:
> Patch Set 7: Code-Review+1
Hi, Quanlong! Can I request to merge the master branch now?
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 25 Aug 2023 09:05:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:30:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 9:
(1 comment)
Attentive and detail-oriented!
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG@21
PS8, Line 21: Connection
> Ack
Done
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:12:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13855/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 07:57:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13818/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 06:29:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13822/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 09:02:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9640/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 14:21:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#8).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two tables to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts table, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections table, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
9 files changed, 312 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/8
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 )
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20358/8//COMMIT_MSG@21
PS8, Line 21: Connection
> nit: "Connection Type"
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:01:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20358
to look at the new patch set (#2).
Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................
IMPALA-10856: Show client hosts and connections in the web UI
This change adds two forms to display client hosts information
and connections information in the sessions Web UI. In the Client
Hosts form, include the following information items:
-- Hostname,
-- Total Connections,
-- Total Sessions,
-- Total Active Sessions,
-- Total Inactive Sessions,
-- Open Queries,
-- Total Queries
In the Connections form, include the following information items:
-- Connection ID,
-- Server Name,
-- User,
-- Delegated User,
-- Network Address,
-- Session IDs
Note that these three items of information: "User", "Delegated User"
and "Network Address" from the Sessions form have been moved to the
Connections form.
Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
---
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M www/sessions.tmpl
8 files changed, 261 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/20358/2
--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>