[GitHub] [iceberg] rdblue commented on a change in pull request #2538: Core: Add delete marker metadata column

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r652129230



##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
##########
@@ -609,6 +611,8 @@ protected StructReader(List<ValueReader<?>> readers, Types.StructType struct, Ma
         } else if (field.fieldId() == MetadataColumns.ROW_POSITION.fieldId()) {
           // track where the _pos field is located for setRowPositionSupplier
           this.posField = pos;
+        } else if (field.fieldId() == MetadataColumns.IS_DELETED.fieldId()) {
+          this.readers[pos] = new ConstantReader<>(false);

Review comment:
       Constants are already handled by this class, see the first branch of this if/else logic. I think that it would make more sense to reuse that rather than create a new constant reader.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org