[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #479: Fix schematron integration test ec parsing

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #479:
URL: https://github.com/apache/incubator-daffodil/pull/479#discussion_r562741428



##########
File path: daffodil-cli/src/it/scala/org/apache/daffodil/schematron/package.scala
##########
@@ -94,7 +94,7 @@ package object schematron {
   private val mustache2 = """\{\{(.+?)}}""".r.unanchored
 
   private val echoEC = s"echo ${if(Util.isWindows) "%errorlevel%" else "$?"}"
-  private val matchEC = regexLine("""\d+""")
+  private val matchEC = regexLine(s"""(?<=\\d+)${if(Util.isWindows) eol else "$"}""")

Review comment:
       Put this discussion into a comment in front of the offending line, maybe somebody will figure it out in the future. Probably CRLF vs. LF related. I think of '\n' as being LF, not CRLF. I think modern regex has \R which is \n or \r\n. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org