You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Pan Jie (JIRA)" <ji...@apache.org> on 2009/02/18 12:43:01 UTC

[jira] Created: (SHINDIG-926) XML/ATOM converter failure for appdata REST api

XML/ATOM converter failure for appdata REST api
-----------------------------------------------

                 Key: SHINDIG-926
                 URL: https://issues.apache.org/jira/browse/SHINDIG-926
             Project: Shindig
          Issue Type: Bug
          Components: PHP
            Reporter: Pan Jie


When using appdata REST api, there are 2 fatal errors:
Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputAtomConverter.php on line 116
Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputXmlConverter.php on line 63
It occurs only when format=xml or format=atom, format=json is ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-926) XML/ATOM converter failure for appdata REST api

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-926.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-BETA2
         Assignee: Chris Chabot

patch never applied to trunk and hasn't been updated since; If this is still an issue please create a new patch based on the current trunk code & reopen the issue; thanks!

> XML/ATOM converter failure for appdata REST api
> -----------------------------------------------
>
>                 Key: SHINDIG-926
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-926
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Pan Jie
>            Assignee: Chris Chabot
>             Fix For: 1.1-BETA2
>
>         Attachments: 20090218.patch
>
>
> When using appdata REST api, there are 2 fatal errors:
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputAtomConverter.php on line 116
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputXmlConverter.php on line 63
> It occurs only when format=xml or format=atom, format=json is ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-926) XML/ATOM converter failure for appdata REST api

Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pan Jie updated SHINDIG-926:
----------------------------

    Attachment: 20090218.patch

Here are things I did in this patch:
1. removed & fixed several unittest to make it pass
2. fixed xml/atom converter and modified these 2 unittests.
3. I removed GadgetContext->instanceGadgetId GadgetContext->getGadgetId GadgetContext->setGadgetId because class GadgetId was deleted.
4. I changed GadgetFactory->fetchGadget from private to protected so that it's easy to be tested. See php/test/gadgets/GadgetTest.php for detail.

> XML/ATOM converter failure for appdata REST api
> -----------------------------------------------
>
>                 Key: SHINDIG-926
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-926
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Pan Jie
>         Attachments: 20090218.patch
>
>
> When using appdata REST api, there are 2 fatal errors:
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputAtomConverter.php on line 116
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputXmlConverter.php on line 63
> It occurs only when format=xml or format=atom, format=json is ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-926) XML/ATOM converter failure for appdata REST api

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680160#action_12680160 ] 

Chris Chabot commented on SHINDIG-926:
--------------------------------------

Hey Pan,

This patch doesn't apply to either the trunk nor to the 1.0.x branch. I don't suppose you could make a new patch that applies cleanly? (and please do mention either in the 'Affected Versions' dropdown or in the description if the patch is intended for the 1.0.x branch, the trunk or both)

Thanks!

> XML/ATOM converter failure for appdata REST api
> -----------------------------------------------
>
>                 Key: SHINDIG-926
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-926
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Pan Jie
>         Attachments: 20090218.patch
>
>
> When using appdata REST api, there are 2 fatal errors:
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputAtomConverter.php on line 116
> Fatal error: Cannot use object of type DataCollection as array in /var/www/html/shindig/php/src/social/converters/OutputXmlConverter.php on line 63
> It occurs only when format=xml or format=atom, format=json is ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.