[jira] [Commented] (SAMZA-736) BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

["Yan Fang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700585#comment-14700585 ] 

Yan Fang commented on SAMZA-736:
--------------------------------

can you add unit test for this as well? :) Thank you.

> BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
> ---------------------------------------------------------------------
>
>                 Key: SAMZA-736
>                 URL: https://issues.apache.org/jira/browse/SAMZA-736
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Yi Pan (Data Infrastructure)
>            Assignee: Aleksandar Pejakovic
>         Attachments: SAMZA-736.0.patch
>
>
> In BrokerProxy code, we are re-trying on exceptions from consumer fetch in an infinite loop. However, when there is OOME thrown from consumer fetch that can not be resolved, the container will stuck forever.
> It is useful to:
> 1) Categorize the type of exceptions that the BrokerProxy can not recover and fail the container
> Or 2) Set an upper bound of retry on "hard" exceptions (e.g. OOME) and fail the container when the upper bound is reached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)