[GitHub] [iceberg] karuppayya commented on a change in pull request #2287: Add iceberg specific description on Spark UI

[GitBox <gi...@apache.org>]

karuppayya commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r593353444



##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -50,6 +55,7 @@
 
   private final SparkSession spark;
   private final JavaSparkContext sparkContext;
+  private AtomicInteger counter = new AtomicInteger();

Review comment:
       Few actions like `Spark3CreateAction`, `Spark3MigrateAction` implement `org.apache.iceberg.actions.Spark3CreateAction` and dont implement `org.apache.iceberg.actions.BaseSparkAction`.
   Hence added the counter to a common location. We cann add the counter and its getters to both `Spark3CreateAction` and `BaseSparkAction`, what do u think @aokolnychyi 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org