You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/02/12 21:46:27 UTC
[jira] Created: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
watchedevent tostring should clearly output the state/type/path
---------------------------------------------------------------
Key: ZOOKEEPER-669
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.2.2, 3.1.2
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.3.0
the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Attachment: ZOOKEEPER-669.patch
this patch cleans up tostring and provides all available information
no test change - exercising this method already covered in the test code
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Attachment: (was: ZOOKEEPER-669.patch)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Status: Patch Available (was: Open)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.2, 3.1.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Attachment: ZOOKEEPER-669.patch
this patch cleans up tostring and provides all available information
no test change - exercising this method already covered in the test code
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch, ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835611#action_12835611 ]
Mahadev konar commented on ZOOKEEPER-669:
-----------------------------------------
+1 the patch looks good! ill wait for hudson to +1 and then commit.....
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Attachment: (was: ZOOKEEPER-669.patch)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837741#action_12837741 ]
Hudson commented on ZOOKEEPER-669:
----------------------------------
Integrated in ZooKeeper-trunk #705 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/705/])
. watchedevent tostring should clearly output the state/type/path (phunt via mahadev)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Status: Open (was: Patch Available)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.2, 3.1.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836095#action_12836095 ]
Hadoop QA commented on ZOOKEEPER-669:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435751/ZOOKEEPER-669.patch
against trunk revision 912052.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/121/console
This message is automatically generated.
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Comment: was deleted
(was: this patch cleans up tostring and provides all available information
no test change - exercising this method already covered in the test code)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-669:
-----------------------------------
Status: Patch Available (was: Open)
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.2, 3.1.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-669:
--------------------------------------
Assignee: Patrick Hunt
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-669) watchedevent tostring should
clearly output the state/type/path
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-669:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat!
> watchedevent tostring should clearly output the state/type/path
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-669
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.2, 3.2.2
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-669.patch
>
>
> the current tostring method is broken
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.