You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/03 22:25:44 UTC

Review Request 68615: Added the `devolve` helper for agent v1 API responses.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68615/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8429
    https://issues.apache.org/jira/browse/MESOS-8429


Repository: mesos


Description
-------

Added the `devolve` helper for agent v1 API responses.


Diffs
-----

  src/internal/devolve.hpp 1bc2a32e70600c785660d0b1d5d63378ffe344cc 
  src/internal/devolve.cpp 93bd975b648888a9d83e34f4d7420b3b49f06d1f 


Diff: https://reviews.apache.org/r/68615/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 68615: Added the `devolve` helper for agent v1 API responses.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68615/#review208283
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 3, 2018, 10:25 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68615/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2018, 10:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8429
>     https://issues.apache.org/jira/browse/MESOS-8429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the `devolve` helper for agent v1 API responses.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp 1bc2a32e70600c785660d0b1d5d63378ffe344cc 
>   src/internal/devolve.cpp 93bd975b648888a9d83e34f4d7420b3b49f06d1f 
> 
> 
> Diff: https://reviews.apache.org/r/68615/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68615: Added the `devolve` helper for agent v1 API responses.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68615/#review208301
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Sept. 4, 2018, 12:25 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68615/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2018, 12:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8429
>     https://issues.apache.org/jira/browse/MESOS-8429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the `devolve` helper for agent v1 API responses.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp 1bc2a32e70600c785660d0b1d5d63378ffe344cc 
>   src/internal/devolve.cpp 93bd975b648888a9d83e34f4d7420b3b49f06d1f 
> 
> 
> Diff: https://reviews.apache.org/r/68615/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>