You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2018/04/18 18:11:33 UTC

[GitHub] spark pull request #19881: [SPARK-22683][CORE] Add a executorAllocationRatio...

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19881#discussion_r182520622
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -26,7 +26,10 @@ import scala.util.control.{ControlThrowable, NonFatal}
     import com.codahale.metrics.{Gauge, MetricRegistry}
     
     import org.apache.spark.internal.Logging
    -import org.apache.spark.internal.config.{DYN_ALLOCATION_MAX_EXECUTORS, DYN_ALLOCATION_MIN_EXECUTORS}
    +import org.apache.spark.internal.config.{
    --- End diff --
    
    I would just make this import org.apache.spark.internal.config._


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org