You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2010/03/19 15:25:27 UTC
[jira] Created: (IO-242) Pre- and post-processing support for
ProxyReader/Writer
Pre- and post-processing support for ProxyReader/Writer
-------------------------------------------------------
Key: IO-242
URL: https://issues.apache.org/jira/browse/IO-242
Project: Commons IO
Issue Type: New Feature
Components: Streams/Writers
Reporter: Jukka Zitting
Assignee: Jukka Zitting
Priority: Minor
Fix For: 2.0
In IO-211 we added protected before/after methods for all read and write operations in ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter. I'll attach the patch for review before committing it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-242) Pre- and post-processing support for
ProxyReader/Writer
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856966#action_12856966 ]
Niall Pemberton commented on IO-242:
------------------------------------
The only comment I would make is that this proxy can now throw NPE if the String/char[]/CharBuffer is null - whereas in the past it would have just passed a null on to the delegate Reader/Writer.
I added test cases for nulls:
http://svn.apache.org/viewvc?view=revision&revision=934024
IMO at least for the ProxyWriter then it shouldn't now be throwing a NPE
> Pre- and post-processing support for ProxyReader/Writer
> -------------------------------------------------------
>
> Key: IO-242
> URL: https://issues.apache.org/jira/browse/IO-242
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0
>
> Attachments: IO-242.patch
>
>
> In IO-211 we added protected before/after methods for all read and write operations in ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter. I'll attach the patch for review before committing it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (IO-242) Pre- and post-processing support for
ProxyReader/Writer
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated IO-242:
-----------------------------
Attachment: IO-242.patch
Proposed patch.
> Pre- and post-processing support for ProxyReader/Writer
> -------------------------------------------------------
>
> Key: IO-242
> URL: https://issues.apache.org/jira/browse/IO-242
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0
>
> Attachments: IO-242.patch
>
>
> In IO-211 we added protected before/after methods for all read and write operations in ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter. I'll attach the patch for review before committing it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-242) Pre- and post-processing support for
ProxyReader/Writer
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856975#action_12856975 ]
Jukka Zitting commented on IO-242:
----------------------------------
Good point. I added null protection in revision 934035.
> Pre- and post-processing support for ProxyReader/Writer
> -------------------------------------------------------
>
> Key: IO-242
> URL: https://issues.apache.org/jira/browse/IO-242
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0
>
> Attachments: IO-242.patch
>
>
> In IO-211 we added protected before/after methods for all read and write operations in ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter. I'll attach the patch for review before committing it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (IO-242) Pre- and post-processing support for
ProxyReader/Writer
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved IO-242.
------------------------------
Resolution: Fixed
Patch committed in revision 933964.
> Pre- and post-processing support for ProxyReader/Writer
> -------------------------------------------------------
>
> Key: IO-242
> URL: https://issues.apache.org/jira/browse/IO-242
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0
>
> Attachments: IO-242.patch
>
>
> In IO-211 we added protected before/after methods for all read and write operations in ProxyInputStream and ProxyOutputStream. I now have a use case where I need similar functionality also for a Writer, so I've implemented the same feature also for ProxyReader and ProxyWriter. I'll attach the patch for review before committing it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira