You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/22 03:34:56 UTC
[GitHub] holdenk commented on a change in pull request #23357: [MINOR][SQL]
Change lead/lag argument name from count to offset
holdenk commented on a change in pull request #23357: [MINOR][SQL] Change lead/lag argument name from count to offset
URL: https://github.com/apache/spark/pull/23357#discussion_r243724645
##########
File path: python/pyspark/sql/functions.py
##########
@@ -828,7 +828,7 @@ def lead(col, count=1, default=None):
:param default: default value
Review comment:
Maybe also document the change in param name in the docstring here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org