You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/22 13:26:58 UTC
[GitHub] [ratis] codings-dan opened a new pull request, #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
codings-dan opened a new pull request, #722:
URL: https://github.com/apache/ratis/pull/722
see https://issues.apache.org/jira/browse/RATIS-1683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #722:
URL: https://github.com/apache/ratis/pull/722#issuecomment-1222400034
@adoroszlai Thanks for helping review the code, let's have a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #722:
URL: https://github.com/apache/ratis/pull/722#issuecomment-1222506570
@adoroszlai Thanks a lot for helping review and merge the pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on a diff in pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #722:
URL: https://github.com/apache/ratis/pull/722#discussion_r951460393
##########
.github/workflows/post-commit.yml:
##########
@@ -172,7 +172,7 @@ jobs:
if: always()
findbugs:
name: findbugs
- runs-on: ubuntu-18.04
+ runs-on: ubuntu-20.04
steps:
Review Comment:
@codings-dan looks like Findbugs has some problem with the Ubuntu 20.04 upgrade. I guess it has to do with Java 11 being default Java version.
```suggestion
runs-on: ubuntu-20.04
steps:
- name: Setup java
uses: actions/setup-java@v1
with:
java-version: 8
```
Can we try with Java 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #722:
URL: https://github.com/apache/ratis/pull/722#issuecomment-1222414853
@adoroszlai hi, it seems that new ci can't be triggered now, do you know what's going on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #722:
URL: https://github.com/apache/ratis/pull/722#issuecomment-1222363542
@adoroszlai Could you help take a look at this pull request? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #722:
URL: https://github.com/apache/ratis/pull/722#issuecomment-1222428766
> it seems that new ci can't be triggered now, do you know what's going on?
Yes, indentation for the new setup-java step does not match the existing one. Sorry about that.
[Invalid workflow file: .github/workflows/post-commit.yml#L176](https://github.com/apache/ratis/actions/runs/2904516017/workflow)
You have an error in your yaml syntax on line 176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai merged pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #722:
URL: https://github.com/apache/ratis/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan closed pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
Posted by GitBox <gi...@apache.org>.
codings-dan closed pull request #722: RATIS-1683. Upgrade ubuntu version from 18.04 to 20.04
URL: https://github.com/apache/ratis/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org