You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/20 16:05:31 UTC

Review Request 63182: RANGER-1849 - Remove PasswordGenerator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1849
    https://issues.apache.org/jira/browse/RANGER-1849


Repository: ranger


Description
-------

PasswordGenerator is not used in any of the scripts and should be removed.


Diffs
-----

  agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 


Diff: https://reviews.apache.org/r/63182/diff/1/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/#review191208
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 16, 2017, 12:18 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63182/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 12:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1849
>     https://issues.apache.org/jira/browse/RANGER-1849
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> PasswordGenerator is not used in any of the scripts and should be removed. Same goes for FileStoreUtil.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/file/FileStoreUtil.java 3f408d76 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 
> 
> 
> Diff: https://reviews.apache.org/r/63182/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/#review193079
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On 十一月 16, 2017, 12:18 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63182/
> -----------------------------------------------------------
> 
> (Updated 十一月 16, 2017, 12:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1849
>     https://issues.apache.org/jira/browse/RANGER-1849
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> PasswordGenerator is not used in any of the scripts and should be removed. Same goes for FileStoreUtil.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/file/FileStoreUtil.java 3f408d76 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 
> 
> 
> Diff: https://reviews.apache.org/r/63182/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/#review193082
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On Nov. 16, 2017, 12:18 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63182/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2017, 12:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1849
>     https://issues.apache.org/jira/browse/RANGER-1849
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> PasswordGenerator is not used in any of the scripts and should be removed. Same goes for FileStoreUtil.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/file/FileStoreUtil.java 3f408d76 
>   agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 
> 
> 
> Diff: https://reviews.apache.org/r/63182/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 12:18 p.m.)


Review request for ranger.


Bugs: RANGER-1849
    https://issues.apache.org/jira/browse/RANGER-1849


Repository: ranger


Description
-------

PasswordGenerator is not used in any of the scripts and should be removed. Same goes for FileStoreUtil.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/file/FileStoreUtil.java 3f408d76 
  agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 


Diff: https://reviews.apache.org/r/63182/diff/2/

Changes: https://reviews.apache.org/r/63182/diff/1-2/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 63182: RANGER-1849 - Remove PasswordGenerator and FileStoreUtil

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63182/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 12:11 p.m.)


Review request for ranger.


Summary (updated)
-----------------

RANGER-1849 - Remove PasswordGenerator and FileStoreUtil


Bugs: RANGER-1849
    https://issues.apache.org/jira/browse/RANGER-1849


Repository: ranger


Description (updated)
-------

PasswordGenerator is not used in any of the scripts and should be removed. Same goes for FileStoreUtil.


Diffs
-----

  agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java a829957a 


Diff: https://reviews.apache.org/r/63182/diff/1/


Testing
-------


Thanks,

Colm O hEigeartaigh