You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Kevan Miller (JIRA)" <ji...@apache.org> on 2007/04/19 22:40:15 UTC

[jira] Created: (OPENEJB-567) EjbJarBuilder.build() should not "deploy" beans

EjbJarBuilder.build() should not "deploy" beans
-----------------------------------------------

                 Key: OPENEJB-567
                 URL: https://issues.apache.org/jira/browse/OPENEJB-567
             Project: OpenEJB
          Issue Type: Bug
    Affects Versions: 3.0
            Reporter: Kevan Miller
         Assigned To: Kevan Miller
             Fix For: 3.0


Currently, EjbJarBuilder.build() is both "building" *and* "deploying". I think these two steps need to be separated. Otherwise, we're deploying prior to the following operations occurring: jaccPermissions, transactionAttributes, and applicationExceptions. 

I have one specific instance where the current ordering (deploy prior to transactionAttributes) is causing a problem during MDB deployment. Specifically: 

CoreDeploymentInfo.getTransactionAttribute(Method) line: 352
EndpointFactory.isDeliveryTransacted(Method) line: 63	
MyResourceAdapter.endpointActivation(MessageEndpointFactory, ActivationSpec) line: 82
MdbContainer.deploy(DeploymentInfo) line: 119	
EjbJarBuilder.build(EjbJarInfo, Map<String,Map<String,EntityManagerFactory>>) line: 63
Assembler.createApplication(AppInfo, ClassLoader) line: 410
...

Currently, the getTransactionAttribute() call will occur before transaction attributes are set by Assembler.createApplication().

Seems like a reasonable fix for this problem is to remove the Container.deploy() out of EjbJarBuilder.build() and into Assembler.createApplication(). I'm testing this option... 

 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENEJB-567) EjbJarBuilder.build() should not "deploy" beans

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller closed OPENEJB-567.
--------------------------------

    Resolution: Fixed

Fixed as described, previously. Processing is now 1) build, 2) configure, 3) deploy.

Also fixed a problem with MDB Container Exception handling

> EjbJarBuilder.build() should not "deploy" beans
> -----------------------------------------------
>
>                 Key: OPENEJB-567
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-567
>             Project: OpenEJB
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>         Assigned To: Kevan Miller
>             Fix For: 3.0
>
>
> Currently, EjbJarBuilder.build() is both "building" *and* "deploying". I think these two steps need to be separated. Otherwise, we're deploying prior to the following operations occurring: jaccPermissions, transactionAttributes, and applicationExceptions. 
> I have one specific instance where the current ordering (deploy prior to transactionAttributes) is causing a problem during MDB deployment. Specifically: 
> CoreDeploymentInfo.getTransactionAttribute(Method) line: 352
> EndpointFactory.isDeliveryTransacted(Method) line: 63	
> MyResourceAdapter.endpointActivation(MessageEndpointFactory, ActivationSpec) line: 82
> MdbContainer.deploy(DeploymentInfo) line: 119	
> EjbJarBuilder.build(EjbJarInfo, Map<String,Map<String,EntityManagerFactory>>) line: 63
> Assembler.createApplication(AppInfo, ClassLoader) line: 410
> ...
> Currently, the getTransactionAttribute() call will occur before transaction attributes are set by Assembler.createApplication().
> Seems like a reasonable fix for this problem is to remove the Container.deploy() out of EjbJarBuilder.build() and into Assembler.createApplication(). I'm testing this option... 
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.