You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/02/06 14:53:42 UTC
[GitHub] [doris] morningman commented on a diff in pull request #16388: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader
morningman commented on code in PR #16388:
URL: https://github.com/apache/doris/pull/16388#discussion_r1097485966
##########
be/src/vec/exec/format/parquet/vparquet_page_index.h:
##########
@@ -33,7 +33,7 @@ class PageIndex {
Status collect_skipped_page_range(tparquet::ColumnIndex* column_index,
ColumnValueRangeType& col_val_range,
const FieldSchema* col_schema,
- std::vector<int>& skipped_ranges);
+ std::vector<int>& skipped_ranges, const cctz::time_zone& utc);
Review Comment:
```suggestion
std::vector<int>& skipped_ranges, const cctz::time_zone& tz);
```
##########
be/src/vec/exec/format/parquet/vparquet_page_index.cpp:
##########
@@ -40,15 +40,17 @@ Status PageIndex::create_skipped_row_range(tparquet::OffsetIndex& offset_index,
Status PageIndex::collect_skipped_page_range(tparquet::ColumnIndex* column_index,
ColumnValueRangeType& col_val_range,
const FieldSchema* col_schema,
- std::vector<int>& skipped_ranges) {
+ std::vector<int>& skipped_ranges,
+ const cctz::time_zone& utc) {
Review Comment:
```suggestion
const cctz::time_zone& tz) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org