You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Jeanne Waldman <je...@oracle.com> on 2006/09/07 00:45:58 UTC
embed key in Icon API - nix it?
I really doubt that anyone is using the embed property that is in the
TextIcon code.
The only renderer I see that is using it is the IconRenderer.
As part of the work to create <span> with attributes from the renderer
and <img>/Text with attributes
from the skinning definition, I'd like to get rid of the embed property
that is in the TextIcon.
Any objections? This is a private API right now, which is why I doubt it
is being used.
- Jeanne
Jeanne Waldman wrote:
> Does anyone know why we have 2 IconRenderers... one in
> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
> Faces-major package)
>
> and one in
> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> (Faces-major package)
>
> I can't tell if the non-Faces-major one is being used anywhere.
>
> Can I delete the non-Faces-major one?
>
> Thanks,
> Jeanne
>
>
>
Re: embed key in Icon API - nix it?
Posted by Jeanne Waldman <je...@oracle.com>.
I'm going to hold off on this. It seems to be used more than I thought,
and it isn't necessary for my work
after all.
I do think we should get rid of the ALIGN constant, since the html align
attribute is deprecated,
but this is a clean-up task.
- Jeanne
Simon Lessard wrote:
> +1
>
> On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
>>
>> I really doubt that anyone is using the embed property that is in the
>> TextIcon code.
>> The only renderer I see that is using it is the IconRenderer.
>> As part of the work to create <span> with attributes from the renderer
>> and <img>/Text with attributes
>> from the skinning definition, I'd like to get rid of the embed property
>> that is in the TextIcon.
>> Any objections? This is a private API right now, which is why I doubt it
>> is being used.
>>
>> - Jeanne
>>
>> Jeanne Waldman wrote:
>>
>> > Does anyone know why we have 2 IconRenderers... one in
>> > org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
>> > Faces-major package)
>> >
>> > and one in
>> > package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
>> > (Faces-major package)
>> >
>> > I can't tell if the non-Faces-major one is being used anywhere.
>> >
>> > Can I delete the non-Faces-major one?
>> >
>> > Thanks,
>> > Jeanne
>> >
>> >
>> >
>>
>>
>
Re: embed key in Icon API - nix it?
Posted by Simon Lessard <si...@gmail.com>.
+1
On 9/6/06, Jeanne Waldman <je...@oracle.com> wrote:
>
> I really doubt that anyone is using the embed property that is in the
> TextIcon code.
> The only renderer I see that is using it is the IconRenderer.
> As part of the work to create <span> with attributes from the renderer
> and <img>/Text with attributes
> from the skinning definition, I'd like to get rid of the embed property
> that is in the TextIcon.
> Any objections? This is a private API right now, which is why I doubt it
> is being used.
>
> - Jeanne
>
> Jeanne Waldman wrote:
>
> > Does anyone know why we have 2 IconRenderers... one in
> > org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non
> > Faces-major package)
> >
> > and one in
> > package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml;
> > (Faces-major package)
> >
> > I can't tell if the non-Faces-major one is being used anywhere.
> >
> > Can I delete the non-Faces-major one?
> >
> > Thanks,
> > Jeanne
> >
> >
> >
>
>