You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/01/08 09:40:33 UTC
[PR] Inherit core theme in React plugins [airflow]
pierrejeambrun opened a new pull request, #60256:
URL: https://github.com/apache/airflow/pull/60256
Remove some unnecessary code so React Plugins can directly inherit the Chakra Theme for Airflow Core without duplicating or copy pasting any core theme.
Now in local development, we use Chakra default theme (black).
<img width="1924" height="938" alt="Screenshot 2026-01-08 at 10 37 35" src="https://github.com/user-attachments/assets/11c6ec74-2970-4a78-a709-ffd47b9443bc" />
When loaded into airflow, nothing changes, theme is smooth and consistent:
<img width="1922" height="935" alt="Screenshot 2026-01-08 at 10 37 01" src="https://github.com/user-attachments/assets/95caf519-380f-45a3-bbe2-af42bf5e7036" />
Also importantly this fixes an issue where the 'plugin theme' when loaded would override the core theme. (which is not what we want). This was an issue for instance if I customized my core theme via the `api.theme` config option, then loading the plugin would restore back the `Airflow Core UI` default theme that was hard copy/pasted into plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60256:
URL: https://github.com/apache/airflow/pull/60256#issuecomment-3725699995
### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/20831046991'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/commit/3e57f1e5ce627050c4cb1bcdcb9735f251bc33c2"><img src='https://img.shields.io/badge/Commit-3e57f1e-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 3e57f1e v3-1-test
```
This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #60256:
URL: https://github.com/apache/airflow/pull/60256#issuecomment-3737960883
Manual backport https://github.com/apache/airflow/pull/60405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60256:
URL: https://github.com/apache/airflow/pull/60256#issuecomment-3740481409
If I apply this change on Edge provider plugin, does this break compatibility with Airflow <3.1.6? Or is it backwards-compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #60256:
URL: https://github.com/apache/airflow/pull/60256#discussion_r2671637857
##########
dev/react-plugin-tools/react_plugin_template/src/global.d.ts:
##########
Review Comment:
Open a follow up PR to apply those changes to the edge3 provider too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #60256:
URL: https://github.com/apache/airflow/pull/60256#issuecomment-3743409082
This is backward compatible. (I mean nothing breaks):
- Old provider on new core -> working, provider will read it's local theme which is the one from airflow core
- new provider on old core -> provider will try to look at the core provided theme, not finding it and default to its local theme (which is the chakra UI default one, which will look a bit different). If we want to make that full compatible we need to keep the full `theme` around. But I think it's a lot of work to maintain for really small gain.
PR here for edge provider:
https://github.com/apache/airflow/pull/60417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Inherit core theme in React plugins [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #60256:
URL: https://github.com/apache/airflow/pull/60256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org