You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/03/31 10:00:16 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #40623: [WIP][SQL] Parameterized `sql()` with literal args
MaxGekk opened a new pull request, #40623:
URL: https://github.com/apache/spark/pull/40623
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155713419
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -234,19 +236,24 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
+ * Supported Data Types</a> for supported value types in Scala/Java. For example, map keys:
+ * "rank", "name", "birthdate"; map values: 1, "Steven", LocalDate.of(2023, 4, 2). Map value
+ * can be a `Column` of literal expression, in that case it is taken as is.
Review Comment:
```suggestion
* can also be a `Column` of literal expression, in that case it is taken as is.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1496177514
It has conflicts with 3.4, @MaxGekk can you create a backport PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1496368421
Here is the backport to `branch-3.4`: https://github.com/apache/spark/pull/40666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
URL: https://github.com/apache/spark/pull/40623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1495260097
If it's guaranteed to be included in 3.4 it's not a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155898543
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
Review Comment:
Here is the PR https://github.com/apache/spark/pull/40644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1156638397
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -53,11 +53,8 @@ message SqlCommand {
// (Required) SQL Query.
string sql = 1;
- // (Optional) A map of parameter names to string values that are parsed as
- // SQL literal expressions. For example, map keys: "rank", "name", "birthdate";
- // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values
- // belonged to SQL comments are skipped while parsing.
- map<string, string> args = 2;
+ // (Optional) A map of parameter names to literal expressions.
+ map<string, Expression.Literal> args = 2;
Review Comment:
cc @grundprinzip are these protocol changes ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1156647732
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -53,11 +53,8 @@ message SqlCommand {
// (Required) SQL Query.
string sql = 1;
- // (Optional) A map of parameter names to string values that are parsed as
- // SQL literal expressions. For example, map keys: "rank", "name", "birthdate";
- // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values
- // belonged to SQL comments are skipped while parsing.
- map<string, string> args = 2;
+ // (Optional) A map of parameter names to literal expressions.
+ map<string, Expression.Literal> args = 2;
Review Comment:
No, this is an incomatible change.
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -108,11 +108,8 @@ message SQL {
// (Required) The SQL query.
string query = 1;
- // (Optional) A map of parameter names to string values that are parsed as
- // SQL literal expressions. For example, map keys: "rank", "name", "birthdate";
- // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values
- // belonged to SQL comments are skipped while parsing.
- map<string, string> args = 2;
+ // (Optional) A map of parameter names to literal expressions.
+ map<string, Expression.Literal> args = 2;
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155712439
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
Review Comment:
looking at the doc, I think we should update it to include the new java datetime api like `LocalDateTime`, and put then at the beginning to promote them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1496220564
@cloud-fan I am working on the backport ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155713419
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -234,19 +236,24 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
+ * Supported Data Types</a> for supported value types in Scala/Java. For example, map keys:
+ * "rank", "name", "birthdate"; map values: 1, "Steven", LocalDate.of(2023, 4, 2). Map value
+ * can be a `Column` of literal expression, in that case it is taken as is.
Review Comment:
```suggestion
* can be also a `Column` of literal expression, in that case it is taken as is.
```
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
+ * Supported Data Types</a> for supported value types in Scala/Java. For example, map keys:
+ * "rank", "name", "birthdate"; map values: 1, "Steven", LocalDate.of(2023, 4, 2). Map value
+ * can be a `Column` of literal expression, in that case it is taken as is.
Review Comment:
```suggestion
* can also be a `Column` of literal expression, in that case it is taken as is.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155712439
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to SQL literal
+ * expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">
Review Comment:
looking at the doc, I think we should update it to include the new java datetime api like `LocalDate`, and put then at the beginning to promote them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1156651960
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -53,11 +53,8 @@ message SqlCommand {
// (Required) SQL Query.
string sql = 1;
- // (Optional) A map of parameter names to string values that are parsed as
- // SQL literal expressions. For example, map keys: "rank", "name", "birthdate";
- // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values
- // belonged to SQL comments are skipped while parsing.
- map<string, string> args = 2;
+ // (Optional) A map of parameter names to literal expressions.
+ map<string, Expression.Literal> args = 2;
Review Comment:
would be valid:
```suggestion
map<string, string> args = 2;
map<string, Expression.Literal> expr_args = 3;
```
so might be
```suggestion
oneof args {
map<string, string> args = 2;
map<string, Expression.Literal> expr_args = 3;
}
```
Please run
```
buf breaking --against "https://github.com/apache/spark/archive/master.zip#strip_components=1,subdir=connector/connect/common/src/main"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1496174032
thanks, merging to master/3.4!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40623:
URL: https://github.com/apache/spark/pull/40623#issuecomment-1495253738
@grundprinzip Spark Connect is not released yet, I think we can still change it? This PR should go to Spark 3.4. cc @xinrong-meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org