You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2024/11/18 05:37:15 UTC

[PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

yaooqinn opened a new pull request, #48872:
URL: https://github.com/apache/spark/pull/48872

   ### What changes were proposed in this pull request?
   This PR makes a follow-up for SPARK-50313, to restore some tests in *SQLQueryTestSuite for ANSI mode. These tests are originally defined in ansi/ folder, in other words, they are not `--IMPORT`-ed, so we need to move them to the default folder where now defaults to ANSI after SPARK-50313.
   
   
   ### Why are the changes needed?
   Improve ANSI test coverage.
   
   
   ### Does this PR introduce _any_ user-facing change?
   NO
   
   
   ### How was this patch tested?
   
   *SQLQueryTestSuite
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   NO
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #48872:
URL: https://github.com/apache/spark/pull/48872#issuecomment-2482414632

   @LuciferYang If java21 is affected, it should have happened in the previous PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #48872:
URL: https://github.com/apache/spark/pull/48872#issuecomment-2484613177

   Thank you @LuciferYang @panbingkun, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48872:
URL: https://github.com/apache/spark/pull/48872#issuecomment-2482359473

   I hope to confirm that this won't affect the testing of Java 21, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #48872: [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode
URL: https://github.com/apache/spark/pull/48872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #48872:
URL: https://github.com/apache/spark/pull/48872#discussion_r1846208645


##########
sql/core/src/test/resources/sql-tests/inputs/group-by-all-mosha.sql:
##########
@@ -12,7 +12,7 @@ SELECT i + 1 AS i1, COUNT(i - 2) ci, f / i AS fi, SUM(i + f) sif FROM stuff GROU
 
 SELECT i AS i, COUNT(i) ci, f AS f, SUM(i + f) sif FROM stuff GROUP BY ALL ORDER BY 1, i, 2, ci, 3, f, 4, sif;
 
-SELECT i + 1, f / i, substring(s, 2, 3), extract(year from t), d / 2, size(a) FROM stuff
+SELECT i + 1, f / i, substring(s, 2, 3), extract(year from t), octet_length(d), size(a) FROM stuff

Review Comment:
   `d / 2` is invalid w/ ANSI on and the failure comes for task execution is unstable, change it to a valid one to remove flakiness in CI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #48872:
URL: https://github.com/apache/spark/pull/48872#discussion_r1846176894


##########
sql/core/src/test/resources/sql-tests/inputs/union.sql:
##########
@@ -9,7 +9,7 @@ FROM   (SELECT * FROM t1
 
 -- Type Coerced Union
 SELECT *
-FROM   (SELECT * FROM t1
+FROM   (SELECT * FROM t1 where c1 = 1

Review Comment:
   Thank you, @panbingkun. Some of the other tests that assert task-side failures might also be flaky.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50313][SQL][TESTS][FOLLOWUP] Restore some tests in *SQLQueryTestSuite for ANSI mode [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #48872:
URL: https://github.com/apache/spark/pull/48872#discussion_r1846093005


##########
sql/core/src/test/resources/sql-tests/inputs/union.sql:
##########
@@ -9,7 +9,7 @@ FROM   (SELECT * FROM t1
 
 -- Type Coerced Union
 SELECT *
-FROM   (SELECT * FROM t1
+FROM   (SELECT * FROM t1 where c1 = 1

Review Comment:
   Great, otherwise a flaky ut will appear, as follows:
   <img width="804" alt="image" src="https://github.com/user-attachments/assets/2c8a6fbb-da37-4936-9517-9a26edb7e47b">
   https://github.com/panbingkun/spark/actions/runs/11887199373/job/33119593602



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org