You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "Xiaoyao708 (via GitHub)" <gi...@apache.org> on 2023/04/17 13:54:15 UTC
[PR] update h2 link in README and README_cn (brpc)
Xiaoyao708 opened a new pull request, #2212:
URL: https://github.com/apache/brpc/pull/2212
### What problem does this PR solve?
Issue Number: #2211
Problem Summary: README h2 link is invalid
### What is changed and the side effects?
Changed: Replace https://http2.github.io/http2-spec to https://httpwg.org/specs/rfc9113.html
Side effects:
- Performance effects(性能影响): No
- Breaking backward compatibility(向后兼容性): Yes
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] update h2 link in README and README_cn (brpc)
Posted by "wasphin (via GitHub)" <gi...@apache.org>.
wasphin merged PR #2212:
URL: https://github.com/apache/brpc/pull/2212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] update h2 link in README and README_cn (brpc)
Posted by "wasphin (via GitHub)" <gi...@apache.org>.
wasphin commented on code in PR #2212:
URL: https://github.com/apache/brpc/pull/2212#discussion_r1169361144
##########
README.md:
##########
@@ -11,7 +11,7 @@
You can use it to:
* Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services
- * restful http/https, [h2](https://http2.github.io/http2-spec)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
+ * restful http/https, [h2](https://httpwg.org/specs/rfc9113.html)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
Review Comment:
the original rfc referred should be rfc7540, which has been obsoleted by rfc9113. haven't check the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] update h2 link in README and README_cn (brpc)
Posted by "Xiaoyao708 (via GitHub)" <gi...@apache.org>.
Xiaoyao708 commented on code in PR #2212:
URL: https://github.com/apache/brpc/pull/2212#discussion_r1169423724
##########
README.md:
##########
@@ -11,7 +11,7 @@
You can use it to:
* Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services
- * restful http/https, [h2](https://http2.github.io/http2-spec)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
+ * restful http/https, [h2](https://httpwg.org/specs/rfc9113.html)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
Review Comment:
httpwg.org/specs/rfc9113.html come from https://http2.github.io
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] update h2 link in README and README_cn (brpc)
Posted by "Xiaoyao708 (via GitHub)" <gi...@apache.org>.
Xiaoyao708 commented on code in PR #2212:
URL: https://github.com/apache/brpc/pull/2212#discussion_r1169423413
##########
README.md:
##########
@@ -11,7 +11,7 @@
You can use it to:
* Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services
- * restful http/https, [h2](https://http2.github.io/http2-spec)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
+ * restful http/https, [h2](https://httpwg.org/specs/rfc9113.html)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
Review Comment:
What should I do next? I don't see what you mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] update h2 link in README and README_cn (brpc)
Posted by "wasphin (via GitHub)" <gi...@apache.org>.
wasphin commented on code in PR #2212:
URL: https://github.com/apache/brpc/pull/2212#discussion_r1169475547
##########
README.md:
##########
@@ -11,7 +11,7 @@
You can use it to:
* Build a server that can talk in multiple protocols (**on same port**), or access all sorts of services
- * restful http/https, [h2](https://http2.github.io/http2-spec)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
+ * restful http/https, [h2](https://httpwg.org/specs/rfc9113.html)/[gRPC](https://grpc.io). using http/h2 in brpc is much more friendly than [libcurl](https://curl.haxx.se/libcurl/). Access protobuf-based protocols with HTTP/h2+json, probably from another language.
Review Comment:
the latest rfc should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org