You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/26 14:09:10 UTC
[GitHub] [iotdb] MrQuansy opened a new pull request, #6786: [IOTDB-3971] Improve the process of writing chunks in compaction for aligned series
MrQuansy opened a new pull request, #6786:
URL: https://github.com/apache/iotdb/pull/6786
see jira: https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-3884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6786: [IOTDB-3971] Improve the process of writing chunks in compaction for aligned series
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6786:
URL: https://github.com/apache/iotdb/pull/6786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] choubenson commented on a diff in pull request #6786: [IOTDB-3971] Improve the process of writing chunks in compaction for aligned series
Posted by GitBox <gi...@apache.org>.
choubenson commented on code in PR #6786:
URL: https://github.com/apache/iotdb/pull/6786#discussion_r932044888
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/writer/InnerSpaceCompactionWriter.java:
##########
@@ -60,7 +63,14 @@ public void write(long timestamp, Object value, int subTaskId) throws IOExceptio
}
@Override
- public void write(long[] timestamps, Object values) {}
+ public void write(TimeColumn timestamps, Column[] columns, int subTaskId, int batchSize)
+ throws IOException {
+ AlignedChunkWriterImpl chunkWriter = (AlignedChunkWriterImpl) this.chunkWriters[subTaskId];
+ chunkWriter.write(timestamps, columns, batchSize);
+ measurementPointCountArray[subTaskId] += batchSize;
Review Comment:
It's unnecessary, remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MrQuansy commented on a diff in pull request #6786: [IOTDB-3971] Improve the process of writing chunks in compaction for aligned series
Posted by GitBox <gi...@apache.org>.
MrQuansy commented on code in PR #6786:
URL: https://github.com/apache/iotdb/pull/6786#discussion_r932437985
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/writer/InnerSpaceCompactionWriter.java:
##########
@@ -60,7 +63,14 @@ public void write(long timestamp, Object value, int subTaskId) throws IOExceptio
}
@Override
- public void write(long[] timestamps, Object values) {}
+ public void write(TimeColumn timestamps, Column[] columns, int subTaskId, int batchSize)
+ throws IOException {
+ AlignedChunkWriterImpl chunkWriter = (AlignedChunkWriterImpl) this.chunkWriters[subTaskId];
+ chunkWriter.write(timestamps, columns, batchSize);
+ measurementPointCountArray[subTaskId] += batchSize;
Review Comment:
Fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org