You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2007/11/21 18:20:45 UTC
Re: svn commit: r27963 - trunk
dlr@tigris.org writes:
> Author: dlr
> Date: Wed Nov 21 09:52:16 2007
> New Revision: 27963
> + SQLite must be built in thread-safe mode (with
> + -DSQLITE_THREADSAFE=1). If building SQLite yourself, you
> + have the option of unpacking the archive into the top of the
> + Subversion source tree and renaming the resulting directory
> + within the Subversion source code from ./sqlite-3.5.2/ to
> + ./sqlite/. Subversion will then build and install it for
> + you.
Earlier versions of sqlite use the name THREADSAFE rather than
SQLITE_THREADSAFE. Setting SQLITE_THREADSAFE may not cause the thread
library to be linked either. Perhaps the configure option
--enable-threadsafe would be better?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r27963 - trunk
Posted by David Glasser <gl...@davidglasser.net>.
On Nov 21, 2007 1:44 PM, Daniel Rall <dl...@collab.net> wrote:
> On Wed, 21 Nov 2007, Philip Martin wrote:
>
> > dlr@tigris.org writes:
> >
> > > Author: dlr
> > > Date: Wed Nov 21 09:52:16 2007
> > > New Revision: 27963
> >
> > > + SQLite must be built in thread-safe mode (with
> > > + -DSQLITE_THREADSAFE=1). If building SQLite yourself, you
> > > + have the option of unpacking the archive into the top of the
> > > + Subversion source tree and renaming the resulting directory
> > > + within the Subversion source code from ./sqlite-3.5.2/ to
> > > + ./sqlite/. Subversion will then build and install it for
> > > + you.
> >
> > Earlier versions of sqlite use the name THREADSAFE rather than
> > SQLITE_THREADSAFE.
>
> Good point. I noticed that as well (it's mentioned in my mails to
> dev@ on this subject).
>
> > Setting SQLITE_THREADSAFE may not cause the thread
> > library to be linked either. Perhaps the configure option
> > --enable-threadsafe would be better?
>
> Good suggestion, Philip. I've made the change in r27969.
> (Incidentally, this became the default in SQLite CVS on Sept. 3rd).
>
> Briefly looking through SQLite's configure history, it appears that
> that option provides a consistent interface to the appropriate C
> preprocessor defines across the SQLite 3.x series (e.g. THREADSAFE in
> previous versions, SQLITE_THREADSAFE in more recent versions).
>
> http://www.sqlite.org/cvstrac/rlog?f=sqlite/configure.ac
>
> Can you confirm?
Additionally, in the absence of SQLITE_THREADSAFE, THREADSAFE is still
supported for legacy reasons.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r27963 - trunk
Posted by Daniel Rall <dl...@collab.net>.
On Wed, 21 Nov 2007, Philip Martin wrote:
> dlr@tigris.org writes:
>
> > Author: dlr
> > Date: Wed Nov 21 09:52:16 2007
> > New Revision: 27963
>
> > + SQLite must be built in thread-safe mode (with
> > + -DSQLITE_THREADSAFE=1). If building SQLite yourself, you
> > + have the option of unpacking the archive into the top of the
> > + Subversion source tree and renaming the resulting directory
> > + within the Subversion source code from ./sqlite-3.5.2/ to
> > + ./sqlite/. Subversion will then build and install it for
> > + you.
>
> Earlier versions of sqlite use the name THREADSAFE rather than
> SQLITE_THREADSAFE.
Good point. I noticed that as well (it's mentioned in my mails to
dev@ on this subject).
> Setting SQLITE_THREADSAFE may not cause the thread
> library to be linked either. Perhaps the configure option
> --enable-threadsafe would be better?
Good suggestion, Philip. I've made the change in r27969.
(Incidentally, this became the default in SQLite CVS on Sept. 3rd).
Briefly looking through SQLite's configure history, it appears that
that option provides a consistent interface to the appropriate C
preprocessor defines across the SQLite 3.x series (e.g. THREADSAFE in
previous versions, SQLITE_THREADSAFE in more recent versions).
http://www.sqlite.org/cvstrac/rlog?f=sqlite/configure.ac
Can you confirm?