You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/25 04:13:23 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24454:
[SPARK-27563][SQL][TEST] automatically get the latest Spark versions in
HiveExternalCatalogVersionsSuite
dongjoon-hyun commented on a change in pull request #24454: [SPARK-27563][SQL][TEST] automatically get the latest Spark versions in HiveExternalCatalogVersionsSuite
URL: https://github.com/apache/spark/pull/24454#discussion_r278390939
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -206,7 +206,16 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
object PROCESS_TABLES extends QueryTest with SQLTestUtils {
// Tests the latest version of every release line.
- val testingVersions = Seq("2.3.3", "2.4.2")
+ lazy val testingVersions: Seq[String] = {
+ import scala.io.Source
+ val versions = Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString
+ .split("\n")
+ .filter(_.contains("""<li><a href="spark-"""))
+ .map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1))
+ .filter(_ < org.apache.spark.SPARK_VERSION)
+ logInfo(s"Testing ${org.apache.spark.SPARK_VERSION} with ${versions.mkString(", ")}.")
Review comment:
Nice! @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org