You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/31 05:25:47 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new issue #431: Feature: route group

liuxiran opened a new issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of Apache APISIX Dashboard, OS, and Browser?
   
   - What happened?
   If possible, provide a way to reproduce the error.
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   
   When multiple projects coexist, it is not convenient if I want to manage all the routes under this project, or to monitor these routes relative to the project in the future. **So I think it would be better to add a route group** ,when create a route , associate it with this group. it would be convenient to find routes, to manage routes` resources or to do monitor.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey edited a comment on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684137827


   @moonming `tags/labels` would be very helpful for users easily to get the wanted `routes/services/upstreams`. Besides, the feature of route grouping we are working on aims at adding support for multi-tenant management for routes, at the top of the hierarchy, which is necessary for enterprise users. The kubernetes you mentioned above is also supporting `namespace` for isolating resources, as well as labels for quick selection. So how about borrow the designs from kubernetes, both `namespace` and `labels`.  Any feedback is much appreciated. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684158042


   @imjoey you are welcome :) 
   I have a concern, will namesapce increase the cost of using and learning for open source users?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684166080


   @moonming yep, that's true and will surely bring some sort of complexity, especially if there are only several routes. While in contrast, if users need to manage a large number of routes, the benefits would be pretty valuable for users.
   
   How about we allow the existence of ungrouped routes. Users can both enjoy the flexibility and this mature management method? 
   > Aha~ The `ungrouped routes` sounds very much like cluster level resources which has no namespace limit in kubernetes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-692503187


   merged and closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-686181702


   Our solution now(refer to existing pr):
   1. create a data table of routeGroup, realize CRUD of routeGroup
   
   1. associate the ID and Name of routeGroup in the route to connect the two. 
   
   The changes to the route:
   * user needs to specify a group when creating a route (or create a new group along with it)
   
   > How about we allow the existence of ungrouped routes. Users can both enjoy the simplicity and this mature management method?
   If you think the above suggestion is more user-friendly, we will also modify the implementation plan @moonming :)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-686181702


   Our solution now(refer to existing pr):
   1. create a data table of routeGroup, realize CRUD of routeGroup
   
   1. associate the ID and Name of routeGroup in the route to connect the two. 
   
   The changes to the route:
   * user needs to specify a group when creating a route (or create a new group along with it)
   
   > How about we allow the existence of ungrouped routes. Users can both enjoy the simplicity and this mature management method?
   
   If you think the above suggestion is more user-friendly, we will also modify the implementation plan @moonming :)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683785047


   > k8s supports tag too, so I think APISIX supports tag is easy:) Thanks, Ming Wen Twitter: _WenMing liuxiran <no...@github.com> 于2020年8月31日周一 下午4:44写道:
   > […](#)
   > @liuxiran <https://github.com/liuxiran> cool, that will be very useful for hundreds of routes. How about add tag for route, service? which is more flexible, a route can have multiple tags tag would be a more flexible and more fine-grained solution, user can it`s also useful for other modules like upstream and so on. And above tag, group would be closer to management, especially when there many users of different roles(dashboard could not have users only with one role), and many projects in this gateway, group would conveniently help us complete the division of route permissions. In fact, group + tag would be more perfectly, but tag may heavly reliance on database,as you have plane to replace the mysql,I think group may go first... — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <[#431 (comment)](https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683650265)>, or unsubscribe <https://github.com/notificatio
 ns/unsubscribe-auth/AGJZBK635TFDDZ2N45FN7LLSDNPF5ANCNFSM4QQDJJTA> .
   
   wow~ It would be better that APISIX can supports tag~!! At the same time, we commit prs which enable apisix-dashboard to support group.
   BTW If you plan to add tag functionality to APISIX, my partners and I would like to contribute to it :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683623439


   @liuxiran cool, that will be very useful for hundreds of routes.
   How about add `tag` for route, service? which is more flexible, a route can have multiple tags


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey edited a comment on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684166080


   @moonming yep, that's true and will surely bring some sort of complexity, especially if there are only several routes. While in contrast, if users need to manage a large number of routes, the benefits would be pretty valuable for users.
   
   How about we allow the existence of ungrouped routes. Users can both enjoy the simplicity and this mature management method? 
   > Aha~ The `ungrouped routes` sounds very much like cluster level resources which has no namespace limit in kubernetes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684137827


   @moonming `tags/labels` would be very helpful for users easily to get the wanted `routes/services/upstreams`. Besides, the feature of route grouping we are working on aims at adding support for multi-tenant management for routes, which is necessary for enterprise users. The kubernetes you mentioned above is also supporting `namespace` for isolating resources, as well as labels for quick selection. So how about borrow the designs from kubernetes, both `namespace` and `labels`.  Any feedback is much appreciated. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683845756


   good job,thx
   
   liuxiran <no...@github.com> 于 2020年8月31日周一 下午9:40写道:
   
   > k8s supports tag too, so I think APISIX supports tag is easy:) Thanks,
   > Ming Wen Twitter: _WenMing liuxiran notifications@github.com
   > 于2020年8月31日周一 下午4:44写道:
   > … <#m_-14532022523113886_>
   > @liuxiran <https://github.com/liuxiran> https://github.com/liuxiran cool,
   > that will be very useful for hundreds of routes. How about add tag for
   > route, service? which is more flexible, a route can have multiple tags tag
   > would be a more flexible and more fine-grained solution, user can it`s also
   > useful for other modules like upstream and so on. And above tag, group
   > would be closer to management, especially when there many users of
   > different roles(dashboard could not have users only with one role), and
   > many projects in this gateway, group would conveniently help us complete
   > the division of route permissions. In fact, group + tag would be more
   > perfectly, but tag may heavly reliance on database,as you have plane to
   > replace the mysql,I think group may go first... — You are receiving this
   > because you were assigned. Reply to this email directly, view it on GitHub <#431
   > (comment)
   > <https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683650265>>,
   > or unsubscribe
   > https://github.com/notifications/unsubscribe-auth/AGJZBK635TFDDZ2N45FN7LLSDNPF5ANCNFSM4QQDJJTA
   > .
   >
   > wow~ It would be better that APISIX can supports tag~!! At the same time,
   > we commit prs which enable apisix-dashboard to support group.
   > BTW If you plan to add tag functionality to APISIX, my partners and I
   > would like to contribute to it :)
   >
   > —
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683785047>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK6EWLBI7WG5DB4EGT3SDOR3JANCNFSM4QQDJJTA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683652629


   k8s supports tag too, so I think APISIX supports tag is easy:)
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   liuxiran <no...@github.com> 于2020年8月31日周一 下午4:44写道:
   
   > @liuxiran <https://github.com/liuxiran> cool, that will be very useful
   > for hundreds of routes.
   > How about add tag for route, service? which is more flexible, a route can
   > have multiple tags
   >
   > tag would be a more flexible and more fine-grained solution👍, user can
   > it`s also useful for other modules like upstream and so on.
   >
   > And above tag, group would be closer to management, especially when there
   > many users of different roles(dashboard could not have users only with one
   > role), and many projects in this gateway, group would conveniently help
   > us complete the division of route permissions.
   >
   > In fact, group + tag would be more perfectly, but tag may heavly reliance
   > on database,as you have plane to replace the mysql,I think group may go
   > first...
   >
   > —
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683650265>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK635TFDDZ2N45FN7LLSDNPF5ANCNFSM4QQDJJTA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-683650265


   > @liuxiran cool, that will be very useful for hundreds of routes.
   > How about add `tag` for route, service? which is more flexible, a route can have multiple tags
   
   `tag` would be a more flexible and more fine-grained solution👍, user can  it`s also useful for other modules like upstream and so on.
   
   And above `tag`, group would be closer to management, especially when there many users of different roles(dashboard could not have users only with one role), and many projects in this gateway, `group` would conveniently help us complete the division of route permissions.
   
   In fact, `group` + `tag` would be more perfectly, but `tag` may heavly reliance on database,as you have plane to replace the mysql,I think `group` may go first...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684140753


   > cool, that will be great if we can support both namesapce and labels. Thanks, Ming Wen Twitter: _WenMing Joey 
   
   @moonming  yeah, that's really awesome for your support. Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #431: Feature: route group

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #431:
URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684139567


   cool, that will be great if we can support both namesapce and labels.
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   Joey <no...@github.com> 于2020年9月1日周二 上午9:31写道:
   
   > @moonming <https://github.com/moonming> tags/labels would be very helpful
   > for users easily to get the wanted routes/services/upstreams. Besides,
   > the feature of route grouping we are working on aims at adding support for
   > multi-tenant management for routes, which is necessary for enterprise
   > users. The kubernetes you mentioned above is also supporting namespace
   > for isolating resources, as well as labels for quick selection. So how
   > about borrow the designs from kubernetes, both namespace and labels. Any
   > feedback is much appreciated. Thanks.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684137827>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBKYI6Y55AEWB6IJOXLTSDRFIZANCNFSM4QQDJJTA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org