[GitHub] [pulsar] sijie commented on a change in pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#discussion_r524475510



##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##########
@@ -66,7 +71,7 @@ public void open(Map<String, Object> config, SourceContext sourceContext) throws
         // Setup schemas
         log.info("Opening pulsar source with config: {}", pulsarSourceConfig);
         Map<String, ConsumerConfig<T>> configs = setupConsumerConfigs();
-
+        consumerExecutor = Executors.newFixedThreadPool(configs.size(),new DefaultThreadFactory(String.format("%s-%s",sourceContext.getSourceName(), sourceContext.getInstanceId())));

Review comment:
       why the pool size is `configs.size`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org