You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/19 20:36:48 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
MaxGekk opened a new pull request #31250:
URL: https://github.com/apache/spark/pull/31250
### What changes were proposed in this pull request?
Add tests to check that v2 table dependents are re-cached after table altering via the commands:
- `ALTER TABLE .. ADD PARTITION`
- `ALTER TABLE .. DROP PARTITION`
- `ALTER TABLE .. RENAME PARTITION`
### Why are the changes needed?
To improve test coverage and prevent regressions.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *.AlterTableAddPartitionSuite"
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *.AlterTableDropPartitionSuite"
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *.AlterTableRenamePartitionSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763880387
**[Test build #134279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134279/testReport)** for PR 31250 at commit [`531157f`](https://github.com/apache/spark/commit/531157f2160c264b38a7b366819737e3cad9b1d7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763898653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134279/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763138778
**[Test build #134239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134239/testReport)** for PR 31250 at commit [`fd9ecd6`](https://github.com/apache/spark/commit/fd9ecd6d06ebc3e5c52c69db0b074ef9876aef94).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763559550
**[Test build #134259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134259/testReport)** for PR 31250 at commit [`e28107d`](https://github.com/apache/spark/commit/e28107dd4cb196a153108bbb5a5e1b6caca11767).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763456214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763197420
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38825/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763456214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763287116
can you fix the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763165764
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38825/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31250:
URL: https://github.com/apache/spark/pull/31250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763190717
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38825/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31250:
URL: https://github.com/apache/spark/pull/31250#discussion_r560998295
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -68,4 +68,35 @@ class AlterTableAddPartitionSuite
checkAnswer(sql(s"SELECT * FROM $t"), Seq(Row(0), Row(1)))
}
}
+
+ test("SPARK-34099, SPARK-34161: keep dependents cashed after table altering") {
Review comment:
At the moment, we cannot because v1 uncaches all dependants. At least now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-764476215
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763898653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134279/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763260508
**[Test build #134239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134239/testReport)** for PR 31250 at commit [`fd9ecd6`](https://github.com/apache/spark/commit/fd9ecd6d06ebc3e5c52c69db0b074ef9876aef94).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763436818
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31250:
URL: https://github.com/apache/spark/pull/31250#discussion_r560985200
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -68,4 +68,35 @@ class AlterTableAddPartitionSuite
checkAnswer(sql(s"SELECT * FROM $t"), Seq(Row(0), Row(1)))
}
}
+
+ test("SPARK-34099, SPARK-34161: keep dependents cashed after table altering") {
Review comment:
BTW can we unify this test between v1 and v2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763789723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763124841
@cloud-fan @sunchao @dongjoon-hyun @HyukjinKwon This is some kind of follow up of https://github.com/apache/spark/pull/31172 and https://github.com/apache/spark/pull/31229 . Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763275022
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134239/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31250:
URL: https://github.com/apache/spark/pull/31250#discussion_r561226917
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -68,4 +68,35 @@ class AlterTableAddPartitionSuite
checkAnswer(sql(s"SELECT * FROM $t"), Seq(Row(0), Row(1)))
}
}
+
+ test("SPARK-34099, SPARK-34161: keep dependents cashed after table altering") {
Review comment:
And we cannot unify v1 and v2 `ALTER TABLE .. ADD PARTITION` because:
- v2 doesn't respect `LOCATION` but support fully partitioned table
- v1 is opposite. It supports `LOCATION` but not fully partitioned table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763898653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134279/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763456190
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38845/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763898653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134279/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763197420
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38825/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-764436018
@cloud-fan @HyukjinKwon Any objections for the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763138778
**[Test build #134239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134239/testReport)** for PR 31250 at commit [`fd9ecd6`](https://github.com/apache/spark/commit/fd9ecd6d06ebc3e5c52c69db0b074ef9876aef94).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763727878
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763560661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134259/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763700828
**[Test build #134279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134279/testReport)** for PR 31250 at commit [`531157f`](https://github.com/apache/spark/commit/531157f2160c264b38a7b366819737e3cad9b1d7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763415794
**[Test build #134259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134259/testReport)** for PR 31250 at commit [`e28107d`](https://github.com/apache/spark/commit/e28107dd4cb196a153108bbb5a5e1b6caca11767).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31250:
URL: https://github.com/apache/spark/pull/31250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763275022
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134239/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763700828
**[Test build #134279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134279/testReport)** for PR 31250 at commit [`531157f`](https://github.com/apache/spark/commit/531157f2160c264b38a7b366819737e3cad9b1d7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763560661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134259/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763754413
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31250:
URL: https://github.com/apache/spark/pull/31250#discussion_r560984190
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -68,4 +68,35 @@ class AlterTableAddPartitionSuite
checkAnswer(sql(s"SELECT * FROM $t"), Seq(Row(0), Row(1)))
}
}
+
+ test("SPARK-34099, SPARK-34161: keep dependents cashed after table altering") {
Review comment:
`cashed`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-764476215
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763415794
**[Test build #134259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134259/testReport)** for PR 31250 at commit [`e28107d`](https://github.com/apache/spark/commit/e28107dd4cb196a153108bbb5a5e1b6caca11767).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-764436018
@cloud-fan @HyukjinKwon Any objections for the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31250: [SPARK-34099][SQL][TESTS] Check re-caching of v2 table dependents after table altering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31250:
URL: https://github.com/apache/spark/pull/31250#issuecomment-763789723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org