[GitHub] [beam] robertwb commented on a diff in pull request #25871: Update default splitting behavior to get fewer, larger, splits

["robertwb (via GitHub)" <gi...@apache.org>]

robertwb commented on code in PR #25871:
URL: https://github.com/apache/beam/pull/25871#discussion_r1139411435


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -290,12 +289,17 @@ public void splitRestriction(
       long estimatedSize = restriction.getEstimatedSizeBytes(pipelineOptions);
       // Split into pieces as close to the default desired bundle size but if that would cause too
       // few splits then prefer to split up to the default desired number of splits.
-      long splitBundleSize =
-          Math.min(
-              DEFAULT_DESIRED_BUNDLE_SIZE_BYTES,
-              Math.max(1L, estimatedSize / DEFAULT_DESIRED_NUM_SPLITS));

Review Comment:
   Should we delete the DEFAULT_DESIRED_NUM_SPLITS constant as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org