You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/30 17:53:35 UTC
[GitHub] [solr] madrob opened a new pull request #779: SOLR-16127 Ordered Executor orphans locks
madrob opened a new pull request #779:
URL: https://github.com/apache/solr/pull/779
https://issues.apache.org/jira/browse/SOLR-16127
I'm not sure if the changes in #776 will fix this or not, but this is a test that fails with the current code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #779: SOLR-16127 Ordered Executor orphans locks
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #779:
URL: https://github.com/apache/solr/pull/779#issuecomment-1083442162
Does the test fail or does it have leaking threads? My fixes wouldn't fix anything other than leaking threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #779: SOLR-16127 Ordered Executor orphans locks
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #779:
URL: https://github.com/apache/solr/pull/779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #779: SOLR-16127 Ordered Executor orphans locks
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #779:
URL: https://github.com/apache/solr/pull/779#issuecomment-1083447511
If fails because I explicitly check for a leaked thread. But it's not leaked by the delegate executor, it's just a thread that never finished executing because it never gets submitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] CaoManhDat commented on pull request #779: SOLR-16127 Ordered Executor orphans locks
Posted by GitBox <gi...@apache.org>.
CaoManhDat commented on pull request #779:
URL: https://github.com/apache/solr/pull/779#issuecomment-1083993308
Looks good to me as well. It is always better to make utility classes safer and reliable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org