[GitHub] [incubator-uniffle] crain-cn commented on a diff in pull request #641: [#545][FOLLOWUP]feat(operator): support specifying custom affinity & tolerations

["crain-cn (via GitHub)" <gi...@apache.org>]

crain-cn commented on code in PR #641:
URL: https://github.com/apache/incubator-uniffle/pull/641#discussion_r1114034083


##########
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go:
##########
@@ -243,6 +239,15 @@ func GenerateDeploy(rss *unifflev1alpha1.RemoteShuffleService, index int) *appsv
 	containers = append(containers, rss.Spec.Coordinator.SidecarContainers...)
 	deploy.Spec.Template.Spec.Containers = containers
 
+	if len(podSpec.Tolerations) == 0 {

Review Comment:
   > Sorry, after a second thought, we may not need this default behavior.
   > 
   > Even if we want to deploy rss to master node, we can always specify the toleration here. So, could you delete these lines. Sorry for the inconvenience.
   
   Deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org