You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by brian Foster <ho...@juno.com> on 2012/02/28 00:07:09 UTC

Review Request: Remove old command line option code from commons

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4071/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann and Paul Ramirez.


Summary
-------

Has been replaced by CAS-CLI


This addresses bug https://issues.apache.org/jira/browse/OODT-392.
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OODT-392


Diffs
-----

  trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOption.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOptionInstance.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/OptionHelpException.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/BeanInfo.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionBeanHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/StdCmdLineOptionHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/parser/CmdLineOptionParser.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/required/RequiredOption.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionUtils.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionsUsagePrinter.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/AllowedArgsCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ArgRegExpCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ClassExistsCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/CmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/FileExistCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/NoRestrictionsCmdLineOptionValidator.java 1294382 

Diff: https://reviews.apache.org/r/4071/diff


Testing
-------


Thanks,

brian


Re: Review Request: Remove old command line option code from commons

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4071/#review5380
-----------------------------------------------------------

Ship it!


+1, ship it!

- Chris


On 2012-02-27 23:07:29, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4071/
> -----------------------------------------------------------
> 
> (Updated 2012-02-27 23:07:29)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> Has been replaced by CAS-CLI
> 
> 
> This addresses bug OODT-392.
>     https://issues.apache.org/jira/browse/OODT-392
> 
> 
> Diffs
> -----
> 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOption.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOptionInstance.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/OptionHelpException.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/BeanInfo.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionBeanHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/StdCmdLineOptionHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/parser/CmdLineOptionParser.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/required/RequiredOption.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionUtils.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionsUsagePrinter.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/AllowedArgsCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ArgRegExpCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ClassExistsCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/CmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/FileExistCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/NoRestrictionsCmdLineOptionValidator.java 1294382 
> 
> Diff: https://reviews.apache.org/r/4071/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian
> 
>


Re: Review Request: Remove old command line option code from commons

Posted by Paul Ramirez <pr...@jpl.nasa.gov>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4071/#review5382
-----------------------------------------------------------

Ship it!


Out with the old in with the new. 

- Paul


On 2012-02-27 23:07:29, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4071/
> -----------------------------------------------------------
> 
> (Updated 2012-02-27 23:07:29)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> -------
> 
> Has been replaced by CAS-CLI
> 
> 
> This addresses bug OODT-392.
>     https://issues.apache.org/jira/browse/OODT-392
> 
> 
> Diffs
> -----
> 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOption.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOptionInstance.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/OptionHelpException.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/BeanInfo.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionBeanHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/StdCmdLineOptionHandler.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/parser/CmdLineOptionParser.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/required/RequiredOption.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionUtils.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionsUsagePrinter.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/AllowedArgsCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ArgRegExpCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ClassExistsCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/CmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/FileExistCmdLineOptionValidator.java 1294382 
>   trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/NoRestrictionsCmdLineOptionValidator.java 1294382 
> 
> Diff: https://reviews.apache.org/r/4071/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian
> 
>


Re: Review Request: Remove old command line option code from commons

Posted by brian Foster <ho...@juno.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4071/
-----------------------------------------------------------

(Updated 2012-02-27 23:07:29.730154)


Review request for oodt, Chris Mattmann and Paul Ramirez.


Summary
-------

Has been replaced by CAS-CLI


This addresses bug OODT-392.
    https://issues.apache.org/jira/browse/OODT-392


Diffs
-----

  trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOption.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/CmdLineOptionInstance.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/OptionHelpException.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/BeanInfo.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionBeanHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/CmdLineOptionHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/handler/StdCmdLineOptionHandler.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/parser/CmdLineOptionParser.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/required/RequiredOption.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionUtils.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/util/CmdLineOptionsUsagePrinter.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/AllowedArgsCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ArgRegExpCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/ClassExistsCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/CmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/FileExistCmdLineOptionValidator.java 1294382 
  trunk/commons/src/main/java/org/apache/oodt/commons/option/validator/NoRestrictionsCmdLineOptionValidator.java 1294382 

Diff: https://reviews.apache.org/r/4071/diff


Testing
-------


Thanks,

brian