[GitHub] [spark] viirya commented on a change in pull request #27008: [SPARK-30353][SQL] Use constraints in SimplifyBinaryComparison optimization

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #27008: [SPARK-30353][SQL] Use constraints in SimplifyBinaryComparison optimization
URL: https://github.com/apache/spark/pull/27008#discussion_r361517700
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -115,6 +114,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
       Batch("Infer Filters", Once,
         InferFiltersFromConstraints) ::
       Batch("Operator Optimization after Inferring Filters", fixedPoint,
+        Seq(SimplifyBinaryComparison) ++
 
 Review comment:
   I think the rules in `operatorOptimizationRuleSet`  are run after inferring filters and `SimplifyBinaryComparison` is in the rules, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org