You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by patricklucas <gi...@git.apache.org> on 2014/10/10 02:34:52 UTC
[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...
GitHub user patricklucas opened a pull request:
https://github.com/apache/storm/pull/290
Remove 'provided' from storm-kafka pom.xml example
Per this documentation, the kafka dependency of storm-kafka is in the
'provided' scope so that users can choose which Scala distribution they
include.
Thus, this example of how to fulfill the dependency should not itself use
the 'provided' scope, or else kafka will still not be included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/storm fix_storm-kafka_pom_example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #290
----
commit f7732e6ab12cfae58b6df2681ab6bdf54de83b29
Author: Patrick Lucas <pl...@yelp.com>
Date: 2014-10-10T00:30:24Z
Remove 'provided' from storm-kafka pom.xml example
Per this documentation, the kafka dependency of storm-kafka is in the
'provided' scope so that users can choose which Scala distribution they
include.
Thus, this example of how to fulfill the dependency should not itself use
the 'provided' scope, or else kafka will still not be included.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/290#issuecomment-60419385
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...
Posted by clockfly <gi...@git.apache.org>.
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/290#issuecomment-61644034
committed into trunk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove 'provided' from storm-kafka pom.xml exa...
Posted by clockfly <gi...@git.apache.org>.
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/290#issuecomment-61643778
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---