You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/22 23:01:27 UTC
[jira] [Commented] (COUCHDB-1447) X-Couch-Update-NewRev header is
missed if custom headers are specified in response of _update handler
[ https://issues.apache.org/jira/browse/COUCHDB-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969888#comment-14969888 ]
ASF GitHub Bot commented on COUCHDB-1447:
-----------------------------------------
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/34
Merge default update response headers with custom ones
COUCHDB-1447
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-couch-mrview 1447-merge-update-headers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit a84a065bf7bdcfc424c8e71590c4ff6af21d6df8
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-10-22T20:21:17Z
Merge default update response headers with custom ones
COUCHDB-1447
commit ac7c5c28ae6a884bf9794b8174169b062b35cd25
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-10-22T20:22:58Z
Reduce duplicated code
----
> X-Couch-Update-NewRev header is missed if custom headers are specified in response of _update handler
> -----------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-1447
> URL: https://issues.apache.org/jira/browse/COUCHDB-1447
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface, View Server Support
> Affects Versions: 1.2, 1.3
> Environment: Apache CouchDB 1.3.0a-a2bea1f-git
> Apache CouchDB 1.2.0a-94e72e7-git
> Reporter: Alexander Shorin
> Priority: Minor
>
> {
> "_id": "_design/dump",
> "_rev": "1-74b49af793bd5ce090712f638c3c920e",
> "updates": {
> "doc": "function(doc, req){ return [doc, {headers: {'Content-Type': 'text/html'}, 'body': '<h1>test</h1>'}]}"
> }
> }
> curl -v -X PUT http://localhost:5984/app%2fdefault/_design/dump/_update/doc/foo
> * About to connect() to localhost port 5984 (#0)
> * Trying 127.0.0.1...
> * connected
> * Connected to localhost (127.0.0.1) port 5984 (#0)
> > PUT /app%2fdefault/_design/dump/_update/doc/foo HTTP/1.1
> > User-Agent: curl/7.24.0 (x86_64-pc-linux-gnu) libcurl/7.24.0 GnuTLS/2.10.5 zlib/1.2.6
> > Host: localhost:5984
> > Accept: */*
> >
> < HTTP/1.1 201 Created
> < Server: CouchDB/1.3.0a-a2bea1f-git (Erlang OTP/R15B)
> < Date: Mon, 19 Mar 2012 01:45:20 GMT
> < Content-Type: text/html
> < Content-Length: 13
> <
> * Connection #0 to host localhost left intact
> <h1>test</h1>* Closing connection #0
> {
> "_id": "_design/dump",
> "_rev": "2-f1c20db4fb28846399ab1cecaa9d2f28",
> "updates": {
> "doc": "function(doc, req){ return [doc, {'body': '<h1>test</h1>'}]}"
> }
> }
> curl -v -X PUT http://localhost:5984/app%2fdefault/_design/dump/_update/doc/foo
> * About to connect() to localhost port 5984 (#0)
> * Trying 127.0.0.1...
> * connected
> * Connected to localhost (127.0.0.1) port 5984 (#0)
> > PUT /app%2fdefault/_design/dump/_update/doc/foo HTTP/1.1
> > User-Agent: curl/7.24.0 (x86_64-pc-linux-gnu) libcurl/7.24.0 GnuTLS/2.10.5 zlib/1.2.6
> > Host: localhost:5984
> > Accept: */*
> >
> < HTTP/1.1 201 Created
> < X-Couch-Update-NewRev: 4-89c1c79a98fc269e474eb64d999a2049
> < Server: CouchDB/1.3.0a-a2bea1f-git (Erlang OTP/R15B)
> < Date: Mon, 19 Mar 2012 01:46:43 GMT
> < Content-Type: text/html; charset=utf-8
> < Content-Length: 13
> <
> * Connection #0 to host localhost left intact
> <h1>test</h1>* Closing connection #0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)