You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <xi...@gmail.com> on 2016/02/11 01:48:27 UTC
Re: Review Request 38117: Added per container SNMP statistics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 12:48 a.m.)
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
rebase
Summary (updated)
-----------------
Added per container SNMP statistics.
Bugs: MESOS-3365
https://issues.apache.org/jira/browse/MESOS-3365
Repository: mesos
Description (updated)
-------
Added per container SNMP statistics.
Diffs (updated)
-----
docs/configuration.md b26a058001dd8419b701a3cb1111ea063a9d58b9
include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ebf820a2813eef32416f1465eff3f6eea153492f
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 1c2fbe934baabd1d816018de0c077bc9f63e9d33
src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d
src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7
src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049
Diff: https://reviews.apache.org/r/38117/diff/
Testing
-------
./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX
Thanks,
Cong Wang
Re: Review Request 38117: Added per container SNMP statistics.
Posted by Cong Wang <xi...@gmail.com>.
> On Feb. 18, 2016, 5:49 p.m., Neil Conway wrote:
> > Seems like this commit should have updated the `v1` version of `mesos.proto`.
>
> Ian Downes wrote:
> Ahh, you're probably right. @cwang could you please submit a fix.
Sure. https://reviews.apache.org/r/43730/
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review119643
-----------------------------------------------------------
On Feb. 11, 2016, 12:48 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:48 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per container SNMP statistics.
>
>
> Diffs
> -----
>
> docs/configuration.md b26a058001dd8419b701a3cb1111ea063a9d58b9
> include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ebf820a2813eef32416f1465eff3f6eea153492f
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 1c2fbe934baabd1d816018de0c077bc9f63e9d33
> src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d
> src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7
> src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049
>
> Diff: https://reviews.apache.org/r/38117/diff/
>
>
> Testing
> -------
>
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 38117: Added per container SNMP statistics.
Posted by Ian Downes <ia...@gmail.com>.
> On Feb. 18, 2016, 9:49 a.m., Neil Conway wrote:
> > Seems like this commit should have updated the `v1` version of `mesos.proto`.
Ahh, you're probably right. @cwang could you please submit a fix.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review119643
-----------------------------------------------------------
On Feb. 10, 2016, 4:48 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 4:48 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per container SNMP statistics.
>
>
> Diffs
> -----
>
> docs/configuration.md b26a058001dd8419b701a3cb1111ea063a9d58b9
> include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ebf820a2813eef32416f1465eff3f6eea153492f
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 1c2fbe934baabd1d816018de0c077bc9f63e9d33
> src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d
> src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7
> src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049
>
> Diff: https://reviews.apache.org/r/38117/diff/
>
>
> Testing
> -------
>
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 38117: Added per container SNMP statistics.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review119643
-----------------------------------------------------------
Seems like this commit should have updated the `v1` version of `mesos.proto`.
- Neil Conway
On Feb. 11, 2016, 12:48 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:48 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per container SNMP statistics.
>
>
> Diffs
> -----
>
> docs/configuration.md b26a058001dd8419b701a3cb1111ea063a9d58b9
> include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ebf820a2813eef32416f1465eff3f6eea153492f
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 1c2fbe934baabd1d816018de0c077bc9f63e9d33
> src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d
> src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7
> src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049
>
> Diff: https://reviews.apache.org/r/38117/diff/
>
>
> Testing
> -------
>
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 38117: Added per container SNMP statistics.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review118813
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38117]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 11, 2016, 12:48 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:48 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3365
> https://issues.apache.org/jira/browse/MESOS-3365
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per container SNMP statistics.
>
>
> Diffs
> -----
>
> docs/configuration.md b26a058001dd8419b701a3cb1111ea063a9d58b9
> include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ebf820a2813eef32416f1465eff3f6eea153492f
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 1c2fbe934baabd1d816018de0c077bc9f63e9d33
> src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d
> src/slave/flags.cpp 2ce7f921c9f53f360143b6927d0aaf78a8b958e7
> src/tests/containerizer/port_mapping_tests.cpp aa9846097feda1a82131b67aa4c782ec3625d049
>
> Diff: https://reviews.apache.org/r/38117/diff/
>
>
> Testing
> -------
>
> ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX
>
>
> Thanks,
>
> Cong Wang
>
>