You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/11 18:18:53 UTC

[kudu-CR](branch-1.17.x) [java] Fix build failures

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21784

to review the following change.


Change subject: [java] Fix build failures
......................................................................

[java] Fix build failures

Recently it was pointed out that older versions of Kudu are failing
when building java due to dependency not present:

> Could not resolve all files for configuration ':buildSrc:compileClasspath'.
   > Could not find gradle-scalafmt-1.14.0.jar (cz.alenkacz:gradle-scalafmt:1.14.0).
     Searched in the following locations:
         https://jcenter.bintray.com/cz/alenkacz/gradle-scalafmt/1.14.0/gradle-scalafmt-1.14.0.jar

This fix updates the dependency's groupId to be fetched as in Maven
Central.

The root cause for the issue is jcenter's sun-setting:
https://jfrog.com/blog/jcenter-sunset/
https://blog.gradle.org/jcenter-shutdown

Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Reviewed-on: http://gerrit.cloudera.org:8080/21692
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 42cc1e68eb5bb13e51ba2fde6a1d6483221706f6)
---
M java/buildSrc/build.gradle
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/21784/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [java] Fix build failures

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21784 )

Change subject: [java] Fix build failures
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/498/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Sep 2024 19:37:00 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [java] Fix build failures

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21784 )

Change subject: [java] Fix build failures
......................................................................

[java] Fix build failures

Recently it was pointed out that older versions of Kudu are failing
when building java due to dependency not present:

> Could not resolve all files for configuration ':buildSrc:compileClasspath'.
   > Could not find gradle-scalafmt-1.14.0.jar (cz.alenkacz:gradle-scalafmt:1.14.0).
     Searched in the following locations:
         https://jcenter.bintray.com/cz/alenkacz/gradle-scalafmt/1.14.0/gradle-scalafmt-1.14.0.jar

This fix updates the dependency's groupId to be fetched as in Maven
Central.

The root cause for the issue is jcenter's sun-setting:
https://jfrog.com/blog/jcenter-sunset/
https://blog.gradle.org/jcenter-shutdown

Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Reviewed-on: http://gerrit.cloudera.org:8080/21692
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 42cc1e68eb5bb13e51ba2fde6a1d6483221706f6)
Reviewed-on: http://gerrit.cloudera.org:8080/21784
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M java/buildSrc/build.gradle
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Abhishek Chennaka: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [java] Fix build failures

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21784 )

Change subject: [java] Fix build failures
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Sep 2024 18:42:14 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [java] Fix build failures

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21784 )

Change subject: [java] Fix build failures
......................................................................


Patch Set 1: Verified+1

Based on the tip of the chain


-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Sep 2024 21:42:53 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [java] Fix build failures

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21784 )

Change subject: [java] Fix build failures
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/498/


-- 
To view, visit http://gerrit.cloudera.org:8080/21784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21784
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Sep 2024 18:19:00 +0000
Gerrit-HasComments: No