You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/04 01:31:27 UTC
[jira] [Commented] (STORM-1129) Storm should use topology name
instead of ids for url in storm UI.
[ https://issues.apache.org/jira/browse/STORM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988592#comment-14988592 ]
ASF GitHub Bot commented on STORM-1129:
---------------------------------------
GitHub user priyank5485 opened a pull request:
https://github.com/apache/storm/pull/854
STORM-1129: Use topology name instead of id in UI calls.
Note that all-topologies-summary has been used to get topology id from a topology name. That involves a few calls to zookeeper which is not ideal. However, UI does not seem to take any significant performance hit. If needed we can handle it possibly using one of the options below. Since its a separate performance issue we can handle it in a separate JIRA.
1. Have nimbus thrift server cache summary for topologies so it does not hit zookeeper every time we try to get topology id from name.
2. Update nimbus thrift api with a method that takes options and use that to do only the minimal necessary interaction with zookeeper for a given option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyank5485/storm STORM-1129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #854
----
commit 77b73af52bdc2d691ae172a1a2905a94395c3c70
Author: Priyank <ps...@hortonworks.com>
Date: 2015-11-04T00:20:50Z
STORM-1129: Use topology name instead of id in UI calls.
----
> Storm should use topology name instead of ids for url in storm UI.
> ------------------------------------------------------------------
>
> Key: STORM-1129
> URL: https://issues.apache.org/jira/browse/STORM-1129
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Priyank Shah
> Assignee: Priyank Shah
>
> Currently, in storm UI details about a topology can be viewed at a URL which has a topology id as a query parameter. When a topology is updated and redeployed a new id is assigned by storm and existing URL(and any bookmarks relying on it) for the topology do not work since the id has changed. We should change it so that topology name is used instead of id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)