You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyoungjun kim <ba...@gmail.com> on 2014/02/26 08:03:09 UTC
Review Request 18509: TAJO-589: Show more informations of a task in web ui
for profiling and monitoring
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18509/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-589
https://issues.apache.org/jira/browse/TAJO-589
Repository: tajo
Description
-------
For profiling and monitoring, we need more informations of a task.
- task progress
- input/output data bytes and number of records
- locality scan rate
- memory usage of sorting or grouping
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatisticsUtil.java 8593db6f28a755fcccaccea2ff35333ef9b1c6dc
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java 9a72da6a39b76b64a9218fb045bba82da57d9f2b
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto f5fff2cfe2cc2ebabcdb5d2571b90bf39a04b704
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java f107c51ac6d59ce17b12bf380b8d31c4a5cc679a
tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java 708eae919a23dfe302a723a0be519bc826201172
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java d2f09226190214906a1c77399f0249c1a93b24bf
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BinaryPhysicalExec.java fc8d25dc48df400bfd3822f5ed8a3fc58cefed7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/EvalExprExec.java 83580f94fdeeb53d67fd8a1bdba6611802b5706f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java 2dfbef429c41706f4a1cf8e6e90e05f4beb61a40
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java e2b926d0a13dd7dc6e76e0fdb30d94b20f54f745
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java a39f4be7d7d6b548921243dd818f7f92d6decfb4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java 0b9bc958a0b4ffd4951ddf4f8518e24c16ba0def
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java c495470fb4c5ed6860abee6dbc5308090110a170
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/UnaryPhysicalExec.java ceeca06097baace2e60a2e6ac13bea60549b63c8
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java 6c187b638fe97ce40d7cf3ded61c9b56a9886513
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java cd18e104cf74111da1815a32fd330b6dc3fdfe79
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java e44947e1a84089d2c1c48f16a336ccb4c0541634
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java 856566a084ecc2c1e40baa92ce80c476adbf1949
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 5fafe5173595a1ab75e949c02f54daa5884bb022
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java 2e4bd70e3426a32515b3195b753531df7c6be26d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java aac5e37ef9e7a2e0f7643a38b73fc6d4709564ed
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 0d3f95e0c30e3d18c265b12ae741d3939c329e0e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 7e1a9bd73e6fe26ddce5183a48cb8ea0f0ba40a4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java 281290c436a91caca5808697a93740011825aa06
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java 222d35557f695321456f38a3c1c9902771f62c1a
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 41252366ff965b3de43915331b222d34695806f6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java c39c06e972dad449693e1ece7d8611756ad09e46
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskHistory.java 2650c4a40f83a1acd1aa420453a3d4720e80cfb2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java 9a38aefd2e5cb383dc794cc6f657537a1a0f7f3b
tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 3fdd2218e52e7e0859b1776d5179b3fca5b34b55
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp 5ba83abf63aac380eba72ffd204862c835e0f612
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/queryunit.jsp 8317ee6e4bab8393a4fce3330b19b9c3b988c08e
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/taskdetail.jsp 4a64d0baa9852a95018699bcc0f99a2a7005daad
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java e1a231add06687ad75faabf6098c3d6c4be2c71d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java 9c96e0e2cfe9c02d15b9a565544bf170e3809544
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/util/TestJSPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case1.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case3.sql PRE-CREATION
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java ed65af60276d941d524da9dc890ee840a21247bc
tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java 553fec9eda5ed34f94faa6f4c54276fd2c0ac85e
tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java 1d4963d9931d02e51a7a9399c961488372f773a2
tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 5c29928058c307f5209c6e126d822ca79b9ef0f9
tajo-storage/src/main/java/org/apache/tajo/storage/Scanner.java 6dca3f2fc4947960a941450376653deab0670580
tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java f9ad2f777cc4c2f6185248a0d77e47629e5aef0f
Diff: https://reviews.apache.org/r/18509/diff/
Testing
-------
Thanks,
hyoungjun kim
Re: Review Request 18509: TAJO-589: Add fine grained progress indicator for
each task
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18509/#review35897
-----------------------------------------------------------
Ship it!
+1
I've fixed some trivial bug, renamed some variables, and added some comments.
This patch is a really great job. It enables Tajo to have fine-grained progress indicator.
It will give QueryMaster more opportunities to exploit collected stats from running queries.
- Hyunsik Choi
On March 1, 2014, 12:31 p.m., hyoungjun kim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18509/
> -----------------------------------------------------------
>
> (Updated March 1, 2014, 12:31 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-589
> https://issues.apache.org/jira/browse/TAJO-589
>
>
> Repository: tajo
>
>
> Description
> -------
>
> For profiling and monitoring, we need more informations of a task.
> - task progress
> - input/output data bytes and number of records
> - locality scan rate
> - memory usage of sorting or grouping
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatisticsUtil.java 8593db6f28a755fcccaccea2ff35333ef9b1c6dc
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java 9a72da6a39b76b64a9218fb045bba82da57d9f2b
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto f5fff2cfe2cc2ebabcdb5d2571b90bf39a04b704
> tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java f107c51ac6d59ce17b12bf380b8d31c4a5cc679a
> tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java 708eae919a23dfe302a723a0be519bc826201172
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java d2f09226190214906a1c77399f0249c1a93b24bf
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BinaryPhysicalExec.java fc8d25dc48df400bfd3822f5ed8a3fc58cefed7e
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/EvalExprExec.java 83580f94fdeeb53d67fd8a1bdba6611802b5706f
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java 2dfbef429c41706f4a1cf8e6e90e05f4beb61a40
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java e2b926d0a13dd7dc6e76e0fdb30d94b20f54f745
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java a39f4be7d7d6b548921243dd818f7f92d6decfb4
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java 0b9bc958a0b4ffd4951ddf4f8518e24c16ba0def
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java c495470fb4c5ed6860abee6dbc5308090110a170
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/UnaryPhysicalExec.java ceeca06097baace2e60a2e6ac13bea60549b63c8
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java 6c187b638fe97ce40d7cf3ded61c9b56a9886513
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java cd18e104cf74111da1815a32fd330b6dc3fdfe79
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java e32612866d0a494d2dccdcf5045936b78b68751b
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java 3350447c7216cba6b679397be4c66866dbaa4fde
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 5fafe5173595a1ab75e949c02f54daa5884bb022
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java 2e4bd70e3426a32515b3195b753531df7c6be26d
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java 8a68c2646794df40a75b0aeeef4bfe2d86203861
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 050370649b49bb609e3fb73b39e599bd32525f8a
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 7e1a9bd73e6fe26ddce5183a48cb8ea0f0ba40a4
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java 281290c436a91caca5808697a93740011825aa06
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java 440887ab8d4a74f17d608c12dc4d84d9ac923120
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 41252366ff965b3de43915331b222d34695806f6
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java c39c06e972dad449693e1ece7d8611756ad09e46
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskHistory.java 2650c4a40f83a1acd1aa420453a3d4720e80cfb2
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java 9a38aefd2e5cb383dc794cc6f657537a1a0f7f3b
> tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 3fdd2218e52e7e0859b1776d5179b3fca5b34b55
> tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp 5ba83abf63aac380eba72ffd204862c835e0f612
> tajo-core/tajo-core-backend/src/main/resources/webapps/worker/queryunit.jsp 8317ee6e4bab8393a4fce3330b19b9c3b988c08e
> tajo-core/tajo-core-backend/src/main/resources/webapps/worker/taskdetail.jsp 4a64d0baa9852a95018699bcc0f99a2a7005daad
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java e1a231add06687ad75faabf6098c3d6c4be2c71d
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java aa72b06fc252db7099a8883017f7a981616c77e5
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/util/TestJSPUtil.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case1.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case2.sql PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case3.sql PRE-CREATION
> tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java ed65af60276d941d524da9dc890ee840a21247bc
> tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java 553fec9eda5ed34f94faa6f4c54276fd2c0ac85e
> tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java 1d4963d9931d02e51a7a9399c961488372f773a2
> tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 5c29928058c307f5209c6e126d822ca79b9ef0f9
> tajo-storage/src/main/java/org/apache/tajo/storage/Scanner.java 6dca3f2fc4947960a941450376653deab0670580
> tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java f9ad2f777cc4c2f6185248a0d77e47629e5aef0f
>
> Diff: https://reviews.apache.org/r/18509/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> hyoungjun kim
>
>
Re: Review Request 18509: TAJO-589: Add fine grained progress indicator for
each task
Posted by hyoungjun kim <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18509/
-----------------------------------------------------------
(Updated March 1, 2014, 12:31 p.m.)
Review request for Tajo.
Bugs: TAJO-589
https://issues.apache.org/jira/browse/TAJO-589
Repository: tajo
Description
-------
For profiling and monitoring, we need more informations of a task.
- task progress
- input/output data bytes and number of records
- locality scan rate
- memory usage of sorting or grouping
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatisticsUtil.java 8593db6f28a755fcccaccea2ff35333ef9b1c6dc
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java 9a72da6a39b76b64a9218fb045bba82da57d9f2b
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto f5fff2cfe2cc2ebabcdb5d2571b90bf39a04b704
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java f107c51ac6d59ce17b12bf380b8d31c4a5cc679a
tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java 708eae919a23dfe302a723a0be519bc826201172
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java d2f09226190214906a1c77399f0249c1a93b24bf
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BinaryPhysicalExec.java fc8d25dc48df400bfd3822f5ed8a3fc58cefed7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/EvalExprExec.java 83580f94fdeeb53d67fd8a1bdba6611802b5706f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java 2dfbef429c41706f4a1cf8e6e90e05f4beb61a40
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java e2b926d0a13dd7dc6e76e0fdb30d94b20f54f745
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java a39f4be7d7d6b548921243dd818f7f92d6decfb4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java 0b9bc958a0b4ffd4951ddf4f8518e24c16ba0def
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java c495470fb4c5ed6860abee6dbc5308090110a170
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/UnaryPhysicalExec.java ceeca06097baace2e60a2e6ac13bea60549b63c8
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java 6c187b638fe97ce40d7cf3ded61c9b56a9886513
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java cd18e104cf74111da1815a32fd330b6dc3fdfe79
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java e32612866d0a494d2dccdcf5045936b78b68751b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java 3350447c7216cba6b679397be4c66866dbaa4fde
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 5fafe5173595a1ab75e949c02f54daa5884bb022
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java 2e4bd70e3426a32515b3195b753531df7c6be26d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java 8a68c2646794df40a75b0aeeef4bfe2d86203861
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 050370649b49bb609e3fb73b39e599bd32525f8a
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 7e1a9bd73e6fe26ddce5183a48cb8ea0f0ba40a4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java 281290c436a91caca5808697a93740011825aa06
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java 440887ab8d4a74f17d608c12dc4d84d9ac923120
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 41252366ff965b3de43915331b222d34695806f6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java c39c06e972dad449693e1ece7d8611756ad09e46
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskHistory.java 2650c4a40f83a1acd1aa420453a3d4720e80cfb2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java 9a38aefd2e5cb383dc794cc6f657537a1a0f7f3b
tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 3fdd2218e52e7e0859b1776d5179b3fca5b34b55
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp 5ba83abf63aac380eba72ffd204862c835e0f612
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/queryunit.jsp 8317ee6e4bab8393a4fce3330b19b9c3b988c08e
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/taskdetail.jsp 4a64d0baa9852a95018699bcc0f99a2a7005daad
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java e1a231add06687ad75faabf6098c3d6c4be2c71d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java aa72b06fc252db7099a8883017f7a981616c77e5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/util/TestJSPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case1.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case3.sql PRE-CREATION
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java ed65af60276d941d524da9dc890ee840a21247bc
tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java 553fec9eda5ed34f94faa6f4c54276fd2c0ac85e
tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java 1d4963d9931d02e51a7a9399c961488372f773a2
tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 5c29928058c307f5209c6e126d822ca79b9ef0f9
tajo-storage/src/main/java/org/apache/tajo/storage/Scanner.java 6dca3f2fc4947960a941450376653deab0670580
tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java f9ad2f777cc4c2f6185248a0d77e47629e5aef0f
Diff: https://reviews.apache.org/r/18509/diff/
Testing
-------
mvn clean install
Thanks,
hyoungjun kim
Re: Review Request 18509: TAJO-589: Add fine grained progress indicator for
each task
Posted by hyoungjun kim <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18509/
-----------------------------------------------------------
(Updated March 1, 2014, 12:31 p.m.)
Review request for Tajo.
Changes
-------
added some comments and rename some variable names.
Summary (updated)
-----------------
TAJO-589: Add fine grained progress indicator for each task
Bugs: TAJO-589
https://issues.apache.org/jira/browse/TAJO-589
Repository: tajo
Description
-------
For profiling and monitoring, we need more informations of a task.
- task progress
- input/output data bytes and number of records
- locality scan rate
- memory usage of sorting or grouping
Diffs (updated)
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatisticsUtil.java 8593db6f28a755fcccaccea2ff35333ef9b1c6dc
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java 9a72da6a39b76b64a9218fb045bba82da57d9f2b
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto f5fff2cfe2cc2ebabcdb5d2571b90bf39a04b704
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java f107c51ac6d59ce17b12bf380b8d31c4a5cc679a
tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java 708eae919a23dfe302a723a0be519bc826201172
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java d2f09226190214906a1c77399f0249c1a93b24bf
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BinaryPhysicalExec.java fc8d25dc48df400bfd3822f5ed8a3fc58cefed7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/EvalExprExec.java 83580f94fdeeb53d67fd8a1bdba6611802b5706f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java 2dfbef429c41706f4a1cf8e6e90e05f4beb61a40
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java e2b926d0a13dd7dc6e76e0fdb30d94b20f54f745
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java a39f4be7d7d6b548921243dd818f7f92d6decfb4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java 0b9bc958a0b4ffd4951ddf4f8518e24c16ba0def
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java c495470fb4c5ed6860abee6dbc5308090110a170
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/UnaryPhysicalExec.java ceeca06097baace2e60a2e6ac13bea60549b63c8
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java 6c187b638fe97ce40d7cf3ded61c9b56a9886513
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java cd18e104cf74111da1815a32fd330b6dc3fdfe79
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java e32612866d0a494d2dccdcf5045936b78b68751b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java 3350447c7216cba6b679397be4c66866dbaa4fde
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 5fafe5173595a1ab75e949c02f54daa5884bb022
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java 2e4bd70e3426a32515b3195b753531df7c6be26d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java 8a68c2646794df40a75b0aeeef4bfe2d86203861
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 050370649b49bb609e3fb73b39e599bd32525f8a
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 7e1a9bd73e6fe26ddce5183a48cb8ea0f0ba40a4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java 281290c436a91caca5808697a93740011825aa06
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java 440887ab8d4a74f17d608c12dc4d84d9ac923120
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 41252366ff965b3de43915331b222d34695806f6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java c39c06e972dad449693e1ece7d8611756ad09e46
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskHistory.java 2650c4a40f83a1acd1aa420453a3d4720e80cfb2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java 9a38aefd2e5cb383dc794cc6f657537a1a0f7f3b
tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 3fdd2218e52e7e0859b1776d5179b3fca5b34b55
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp 5ba83abf63aac380eba72ffd204862c835e0f612
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/queryunit.jsp 8317ee6e4bab8393a4fce3330b19b9c3b988c08e
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/taskdetail.jsp 4a64d0baa9852a95018699bcc0f99a2a7005daad
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java e1a231add06687ad75faabf6098c3d6c4be2c71d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java aa72b06fc252db7099a8883017f7a981616c77e5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/util/TestJSPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case1.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case3.sql PRE-CREATION
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java ed65af60276d941d524da9dc890ee840a21247bc
tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java 553fec9eda5ed34f94faa6f4c54276fd2c0ac85e
tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java 1d4963d9931d02e51a7a9399c961488372f773a2
tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 5c29928058c307f5209c6e126d822ca79b9ef0f9
tajo-storage/src/main/java/org/apache/tajo/storage/Scanner.java 6dca3f2fc4947960a941450376653deab0670580
tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java f9ad2f777cc4c2f6185248a0d77e47629e5aef0f
Diff: https://reviews.apache.org/r/18509/diff/
Testing
-------
mvn clean install
Thanks,
hyoungjun kim
Re: Review Request 18509: TAJO-589: Show more informations of a task in web
ui for profiling and monitoring
Posted by hyoungjun kim <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18509/
-----------------------------------------------------------
(Updated Feb. 28, 2014, 2:33 p.m.)
Review request for Tajo.
Bugs: TAJO-589
https://issues.apache.org/jira/browse/TAJO-589
Repository: tajo
Description
-------
For profiling and monitoring, we need more informations of a task.
- task progress
- input/output data bytes and number of records
- locality scan rate
- memory usage of sorting or grouping
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatisticsUtil.java 8593db6f28a755fcccaccea2ff35333ef9b1c6dc
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/TableStats.java 9a72da6a39b76b64a9218fb045bba82da57d9f2b
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto f5fff2cfe2cc2ebabcdb5d2571b90bf39a04b704
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java f107c51ac6d59ce17b12bf380b8d31c4a5cc679a
tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java 708eae919a23dfe302a723a0be519bc826201172
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java d2f09226190214906a1c77399f0249c1a93b24bf
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BinaryPhysicalExec.java fc8d25dc48df400bfd3822f5ed8a3fc58cefed7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/EvalExprExec.java 83580f94fdeeb53d67fd8a1bdba6611802b5706f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java 2dfbef429c41706f4a1cf8e6e90e05f4beb61a40
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java e2b926d0a13dd7dc6e76e0fdb30d94b20f54f745
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java a39f4be7d7d6b548921243dd818f7f92d6decfb4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java 0b9bc958a0b4ffd4951ddf4f8518e24c16ba0def
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java c495470fb4c5ed6860abee6dbc5308090110a170
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/UnaryPhysicalExec.java ceeca06097baace2e60a2e6ac13bea60549b63c8
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java 6c187b638fe97ce40d7cf3ded61c9b56a9886513
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java cd18e104cf74111da1815a32fd330b6dc3fdfe79
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java e44947e1a84089d2c1c48f16a336ccb4c0541634
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java 856566a084ecc2c1e40baa92ce80c476adbf1949
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 5fafe5173595a1ab75e949c02f54daa5884bb022
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java 2e4bd70e3426a32515b3195b753531df7c6be26d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java aac5e37ef9e7a2e0f7643a38b73fc6d4709564ed
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 0d3f95e0c30e3d18c265b12ae741d3939c329e0e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 7e1a9bd73e6fe26ddce5183a48cb8ea0f0ba40a4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java 281290c436a91caca5808697a93740011825aa06
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java 222d35557f695321456f38a3c1c9902771f62c1a
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 41252366ff965b3de43915331b222d34695806f6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java c39c06e972dad449693e1ece7d8611756ad09e46
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskHistory.java 2650c4a40f83a1acd1aa420453a3d4720e80cfb2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java 9a38aefd2e5cb383dc794cc6f657537a1a0f7f3b
tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 3fdd2218e52e7e0859b1776d5179b3fca5b34b55
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp 5ba83abf63aac380eba72ffd204862c835e0f612
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/queryunit.jsp 8317ee6e4bab8393a4fce3330b19b9c3b988c08e
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/taskdetail.jsp 4a64d0baa9852a95018699bcc0f99a2a7005daad
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java e1a231add06687ad75faabf6098c3d6c4be2c71d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java 9c96e0e2cfe9c02d15b9a565544bf170e3809544
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/util/TestJSPUtil.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case1.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case2.sql PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestQueryUnitStatusUpdate/case3.sql PRE-CREATION
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java ed65af60276d941d524da9dc890ee840a21247bc
tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java 553fec9eda5ed34f94faa6f4c54276fd2c0ac85e
tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java 1d4963d9931d02e51a7a9399c961488372f773a2
tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java 5c29928058c307f5209c6e126d822ca79b9ef0f9
tajo-storage/src/main/java/org/apache/tajo/storage/Scanner.java 6dca3f2fc4947960a941450376653deab0670580
tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java f9ad2f777cc4c2f6185248a0d77e47629e5aef0f
Diff: https://reviews.apache.org/r/18509/diff/
Testing (updated)
-------
mvn clean install
Thanks,
hyoungjun kim