You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Aleksey Kuznetsov <al...@gmail.com> on 2018/07/26 15:24:49 UTC

Re: iep-6 metrics ticket review

Hi, Igniters!

I have the ticket [1] reviewed, it introduce large changes to cache.

How can I assure it causes no performance drop ?

[1] : https://issues.apache.org/jira/browse/IGNITE-6846

ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
valentin.kulichenko@gmail.com>:

> This is on my plate, will try to take a look this week.
>
> -Val
>
> On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org> wrote:
>
> > Val,
> >
> > As an initial reviewer and reporter, could you have a look and sign the
> > contribution off?
> >
> > --
> > Denis
> >
> > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
> > alkuznetsov.sb@gmail.com
> > > wrote:
> >
> > > Hi ,Igniters!
> > >
> > > Do we still need this ticket, about invoke metrics : [1] ?
> > >
> > > If yes, than could somebody review it ?
> > >
> > > If no, should we close this ticket ?
> > >
> > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> > > --
> > >
> > > *Best Regards,*
> > >
> > > *Kuznetsov Aleksey*
> > >
> >
>

Re: iep-6 metrics ticket review

Posted by Dmitriy Pavlov <dp...@gmail.com>.

Hi,

Alexey, yes, that's right, it seems, we discussed this. Merged to master.

Alexey, thank you for contribution,
Dmitriy, Val, thank you for review.
Ilya, thank you for checking solution performance.

Sincerely,
Dmitriy Pavlov

вт, 31 июл. 2018 г. в 14:42, Aleksey Kuznetsov <al...@gmail.com>:

> Hi!
>
> Yes, I added `GridCacheNearAtomicMetricsSelfTest` to test atomic
> configuration, but `testNearRead` is broken.
>
> We agreed to proceed with this test broken and fix it later : [1]
>
> [1] :
> https://issues.apache.org/jira/browse/IGNITE-6846?focusedCommentId=16417786&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16417786
>
> I'm going to fix it after current ticket.
>
> вт, 31 июл. 2018 г. в 14:28, Dmitriy Pavlov <dp...@gmail.com>:
> >
> > Hi Alexey,
> >
> > I've found test failure, which is not executied in master
> >
> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=8815184974848592565&branch=pull%2F3148%2Fhead&tab=testDetails&branch_IgniteTests24Java8=__all_branches__
> >
> > Is it newly contributed test? Why it fails in PR?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > вт, 31 июл. 2018 г. в 13:01, Dmitriy Pavlov <dp...@gmail.com>:
> >
> > > Hi Ilya,
> > >
> > > Great, thanks! I'm going to apply this patch.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > вт, 31 июл. 2018 г. в 12:35, Ilya Suntsov <is...@gridgain.com>:
> > >
> > >> Dmitry G.,
> > >>
> > >> I've run yardstick pds benchmarks against PR-3148 and master and can
> > >> confirm that fixes from PR don't affect performance.
> > >>
> > >> 2018-07-26 18:38 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > >>
> > >>> Hi Ilya,
> > >>>
> > >>> We all agreed change is good, but we'd like to be absolutely sure
> there
> > >>> is no performance drop. Dmitriy G. was one from reviewer, so I hope
> he
> > >>> would provide any additional info about change.
> > >>>
> > >>> Could you please assist here?
> > >>>
> > >>> Sincerely,
> > >>> Dmitriy Pavlov
> > >>>
> > >>> чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <
> alkuznetsov.sb@gmail.com
> > >>> >:
> > >>>
> > >>>> Hi, Igniters!
> > >>>>
> > >>>> I have the ticket [1] reviewed, it introduce large changes to cache.
> > >>>>
> > >>>> How can I assure it causes no performance drop ?
> > >>>>
> > >>>> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> > >>>>
> > >>>> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
> > >>>> valentin.kulichenko@gmail.com>:
> > >>>>
> > >>>> > This is on my plate, will try to take a look this week.
> > >>>> >
> > >>>> > -Val
> > >>>> >
> > >>>> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org>
> > >>>> wrote:
> > >>>> >
> > >>>> > > Val,
> > >>>> > >
> > >>>> > > As an initial reviewer and reporter, could you have a look and
> sign
> > >>>> the
> > >>>> > > contribution off?
> > >>>> > >
> > >>>> > > --
> > >>>> > > Denis
> > >>>> > >
> > >>>> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
> > >>>> > > alkuznetsov.sb@gmail.com
> > >>>> > > > wrote:
> > >>>> > >
> > >>>> > > > Hi ,Igniters!
> > >>>> > > >
> > >>>> > > > Do we still need this ticket, about invoke metrics : [1] ?
> > >>>> > > >
> > >>>> > > > If yes, than could somebody review it ?
> > >>>> > > >
> > >>>> > > > If no, should we close this ticket ?
> > >>>> > > >
> > >>>> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> > >>>> > > > --
> > >>>> > > >
> > >>>> > > > *Best Regards,*
> > >>>> > > >
> > >>>> > > > *Kuznetsov Aleksey*
> > >>>> > > >
> > >>>> > >
> > >>>> >
> > >>>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Best Regards,
> > >> Ilya Suntsov
> > >> email: isuntsov@gridgain.com
> > >> *GridGain Systems*
> > >> www.gridgain.com
> > >>
> > >
>

Re: iep-6 metrics ticket review

Posted by Aleksey Kuznetsov <al...@gmail.com>.

Hi!

Yes, I added `GridCacheNearAtomicMetricsSelfTest` to test atomic
configuration, but `testNearRead` is broken.

We agreed to proceed with this test broken and fix it later : [1]

[1] : https://issues.apache.org/jira/browse/IGNITE-6846?focusedCommentId=16417786&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16417786

I'm going to fix it after current ticket.

вт, 31 июл. 2018 г. в 14:28, Dmitriy Pavlov <dp...@gmail.com>:
>
> Hi Alexey,
>
> I've found test failure, which is not executied in master
> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=8815184974848592565&branch=pull%2F3148%2Fhead&tab=testDetails&branch_IgniteTests24Java8=__all_branches__
>
> Is it newly contributed test? Why it fails in PR?
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 31 июл. 2018 г. в 13:01, Dmitriy Pavlov <dp...@gmail.com>:
>
> > Hi Ilya,
> >
> > Great, thanks! I'm going to apply this patch.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > вт, 31 июл. 2018 г. в 12:35, Ilya Suntsov <is...@gridgain.com>:
> >
> >> Dmitry G.,
> >>
> >> I've run yardstick pds benchmarks against PR-3148 and master and can
> >> confirm that fixes from PR don't affect performance.
> >>
> >> 2018-07-26 18:38 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> >>
> >>> Hi Ilya,
> >>>
> >>> We all agreed change is good, but we'd like to be absolutely sure there
> >>> is no performance drop. Dmitriy G. was one from reviewer, so I hope he
> >>> would provide any additional info about change.
> >>>
> >>> Could you please assist here?
> >>>
> >>> Sincerely,
> >>> Dmitriy Pavlov
> >>>
> >>> чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <alkuznetsov.sb@gmail.com
> >>> >:
> >>>
> >>>> Hi, Igniters!
> >>>>
> >>>> I have the ticket [1] reviewed, it introduce large changes to cache.
> >>>>
> >>>> How can I assure it causes no performance drop ?
> >>>>
> >>>> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> >>>>
> >>>> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
> >>>> valentin.kulichenko@gmail.com>:
> >>>>
> >>>> > This is on my plate, will try to take a look this week.
> >>>> >
> >>>> > -Val
> >>>> >
> >>>> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org>
> >>>> wrote:
> >>>> >
> >>>> > > Val,
> >>>> > >
> >>>> > > As an initial reviewer and reporter, could you have a look and sign
> >>>> the
> >>>> > > contribution off?
> >>>> > >
> >>>> > > --
> >>>> > > Denis
> >>>> > >
> >>>> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
> >>>> > > alkuznetsov.sb@gmail.com
> >>>> > > > wrote:
> >>>> > >
> >>>> > > > Hi ,Igniters!
> >>>> > > >
> >>>> > > > Do we still need this ticket, about invoke metrics : [1] ?
> >>>> > > >
> >>>> > > > If yes, than could somebody review it ?
> >>>> > > >
> >>>> > > > If no, should we close this ticket ?
> >>>> > > >
> >>>> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> >>>> > > > --
> >>>> > > >
> >>>> > > > *Best Regards,*
> >>>> > > >
> >>>> > > > *Kuznetsov Aleksey*
> >>>> > > >
> >>>> > >
> >>>> >
> >>>>
> >>>
> >>
> >>
> >> --
> >> Best Regards,
> >> Ilya Suntsov
> >> email: isuntsov@gridgain.com
> >> *GridGain Systems*
> >> www.gridgain.com
> >>
> >

Re: iep-6 metrics ticket review

Posted by Dmitriy Pavlov <dp...@gmail.com>.

Hi Alexey,

I've found test failure, which is not executied in master
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=8815184974848592565&branch=pull%2F3148%2Fhead&tab=testDetails&branch_IgniteTests24Java8=__all_branches__

Is it newly contributed test? Why it fails in PR?

Sincerely,
Dmitriy Pavlov

вт, 31 июл. 2018 г. в 13:01, Dmitriy Pavlov <dp...@gmail.com>:

> Hi Ilya,
>
> Great, thanks! I'm going to apply this patch.
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 31 июл. 2018 г. в 12:35, Ilya Suntsov <is...@gridgain.com>:
>
>> Dmitry G.,
>>
>> I've run yardstick pds benchmarks against PR-3148 and master and can
>> confirm that fixes from PR don't affect performance.
>>
>> 2018-07-26 18:38 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
>>
>>> Hi Ilya,
>>>
>>> We all agreed change is good, but we'd like to be absolutely sure there
>>> is no performance drop. Dmitriy G. was one from reviewer, so I hope he
>>> would provide any additional info about change.
>>>
>>> Could you please assist here?
>>>
>>> Sincerely,
>>> Dmitriy Pavlov
>>>
>>> чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <alkuznetsov.sb@gmail.com
>>> >:
>>>
>>>> Hi, Igniters!
>>>>
>>>> I have the ticket [1] reviewed, it introduce large changes to cache.
>>>>
>>>> How can I assure it causes no performance drop ?
>>>>
>>>> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>>>>
>>>> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
>>>> valentin.kulichenko@gmail.com>:
>>>>
>>>> > This is on my plate, will try to take a look this week.
>>>> >
>>>> > -Val
>>>> >
>>>> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org>
>>>> wrote:
>>>> >
>>>> > > Val,
>>>> > >
>>>> > > As an initial reviewer and reporter, could you have a look and sign
>>>> the
>>>> > > contribution off?
>>>> > >
>>>> > > --
>>>> > > Denis
>>>> > >
>>>> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
>>>> > > alkuznetsov.sb@gmail.com
>>>> > > > wrote:
>>>> > >
>>>> > > > Hi ,Igniters!
>>>> > > >
>>>> > > > Do we still need this ticket, about invoke metrics : [1] ?
>>>> > > >
>>>> > > > If yes, than could somebody review it ?
>>>> > > >
>>>> > > > If no, should we close this ticket ?
>>>> > > >
>>>> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>>>> > > > --
>>>> > > >
>>>> > > > *Best Regards,*
>>>> > > >
>>>> > > > *Kuznetsov Aleksey*
>>>> > > >
>>>> > >
>>>> >
>>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Ilya Suntsov
>> email: isuntsov@gridgain.com
>> *GridGain Systems*
>> www.gridgain.com
>>
>

Re: iep-6 metrics ticket review

Posted by Dmitriy Pavlov <dp...@gmail.com>.

Hi Ilya,

Great, thanks! I'm going to apply this patch.

Sincerely,
Dmitriy Pavlov

вт, 31 июл. 2018 г. в 12:35, Ilya Suntsov <is...@gridgain.com>:

> Dmitry G.,
>
> I've run yardstick pds benchmarks against PR-3148 and master and can
> confirm that fixes from PR don't affect performance.
>
> 2018-07-26 18:38 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
>
>> Hi Ilya,
>>
>> We all agreed change is good, but we'd like to be absolutely sure there
>> is no performance drop. Dmitriy G. was one from reviewer, so I hope he
>> would provide any additional info about change.
>>
>> Could you please assist here?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <alkuznetsov.sb@gmail.com
>> >:
>>
>>> Hi, Igniters!
>>>
>>> I have the ticket [1] reviewed, it introduce large changes to cache.
>>>
>>> How can I assure it causes no performance drop ?
>>>
>>> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>>>
>>> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
>>> valentin.kulichenko@gmail.com>:
>>>
>>> > This is on my plate, will try to take a look this week.
>>> >
>>> > -Val
>>> >
>>> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org>
>>> wrote:
>>> >
>>> > > Val,
>>> > >
>>> > > As an initial reviewer and reporter, could you have a look and sign
>>> the
>>> > > contribution off?
>>> > >
>>> > > --
>>> > > Denis
>>> > >
>>> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
>>> > > alkuznetsov.sb@gmail.com
>>> > > > wrote:
>>> > >
>>> > > > Hi ,Igniters!
>>> > > >
>>> > > > Do we still need this ticket, about invoke metrics : [1] ?
>>> > > >
>>> > > > If yes, than could somebody review it ?
>>> > > >
>>> > > > If no, should we close this ticket ?
>>> > > >
>>> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>>> > > > --
>>> > > >
>>> > > > *Best Regards,*
>>> > > >
>>> > > > *Kuznetsov Aleksey*
>>> > > >
>>> > >
>>> >
>>>
>>
>
>
> --
> Best Regards,
> Ilya Suntsov
> email: isuntsov@gridgain.com
> *GridGain Systems*
> www.gridgain.com
>

Re: iep-6 metrics ticket review

Posted by Ilya Suntsov <is...@gridgain.com>.

Dmitry G.,

I've run yardstick pds benchmarks against PR-3148 and master and can
confirm that fixes from PR don't affect performance.

2018-07-26 18:38 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:

> Hi Ilya,
>
> We all agreed change is good, but we'd like to be absolutely sure there is
> no performance drop. Dmitriy G. was one from reviewer, so I hope he would
> provide any additional info about change.
>
> Could you please assist here?
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <al...@gmail.com>:
>
>> Hi, Igniters!
>>
>> I have the ticket [1] reviewed, it introduce large changes to cache.
>>
>> How can I assure it causes no performance drop ?
>>
>> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>>
>> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
>> valentin.kulichenko@gmail.com>:
>>
>> > This is on my plate, will try to take a look this week.
>> >
>> > -Val
>> >
>> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org> wrote:
>> >
>> > > Val,
>> > >
>> > > As an initial reviewer and reporter, could you have a look and sign
>> the
>> > > contribution off?
>> > >
>> > > --
>> > > Denis
>> > >
>> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
>> > > alkuznetsov.sb@gmail.com
>> > > > wrote:
>> > >
>> > > > Hi ,Igniters!
>> > > >
>> > > > Do we still need this ticket, about invoke metrics : [1] ?
>> > > >
>> > > > If yes, than could somebody review it ?
>> > > >
>> > > > If no, should we close this ticket ?
>> > > >
>> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>> > > > --
>> > > >
>> > > > *Best Regards,*
>> > > >
>> > > > *Kuznetsov Aleksey*
>> > > >
>> > >
>> >
>>
>


-- 
Best Regards,
Ilya Suntsov
email: isuntsov@gridgain.com
*GridGain Systems*
www.gridgain.com

Re: iep-6 metrics ticket review

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Ilya,

We all agreed change is good, but we'd like to be absolutely sure there is
no performance drop. Dmitriy G. was one from reviewer, so I hope he would
provide any additional info about change.

Could you please assist here?

Sincerely,
Dmitriy Pavlov

чт, 26 июл. 2018 г. в 18:25, Aleksey Kuznetsov <al...@gmail.com>:

> Hi, Igniters!
>
> I have the ticket [1] reviewed, it introduce large changes to cache.
>
> How can I assure it causes no performance drop ?
>
> [1] : https://issues.apache.org/jira/browse/IGNITE-6846
>
> ср, 11 апр. 2018 г. в 3:32, Valentin Kulichenko <
> valentin.kulichenko@gmail.com>:
>
> > This is on my plate, will try to take a look this week.
> >
> > -Val
> >
> > On Mon, Apr 9, 2018 at 10:28 AM, Denis Magda <dm...@apache.org> wrote:
> >
> > > Val,
> > >
> > > As an initial reviewer and reporter, could you have a look and sign the
> > > contribution off?
> > >
> > > --
> > > Denis
> > >
> > > On Mon, Apr 9, 2018 at 12:56 AM, Aleksey Kuznetsov <
> > > alkuznetsov.sb@gmail.com
> > > > wrote:
> > >
> > > > Hi ,Igniters!
> > > >
> > > > Do we still need this ticket, about invoke metrics : [1] ?
> > > >
> > > > If yes, than could somebody review it ?
> > > >
> > > > If no, should we close this ticket ?
> > > >
> > > > [1] : https://issues.apache.org/jira/browse/IGNITE-6846
> > > > --
> > > >
> > > > *Best Regards,*
> > > >
> > > > *Kuznetsov Aleksey*
> > > >
> > >
> >
>