Re: [PR] refactor(tags): align ExportTagsCommand with ExportModelsCommand [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #42339:
URL: https://github.com/apache/superset/pull/42339#issuecomment-5243913581

   Thanks for chasing this down, @prathamesh04. Pre-commit's still red on the latest push, mypy's catching type errors in `run()` (superset/commands/tag/export.py around lines 58-80), the dashboard/chart id lists built there don't match the declared `Optional[Union[int, List[Union[int, str]]]]` signature. Worth tightening those types rather than leaving the mismatch. Happy to take another look once that's green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org