You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/22 23:35:25 UTC

[GitHub] [trafficcontrol] rob05c commented on pull request #6366: T3C remove extraneous logs

rob05c commented on pull request #6366:
URL: https://github.com/apache/trafficcontrol/pull/6366#issuecomment-976008102


   I'm definitely +1 on this, it's great work cleaning up the tests and taking advantage of Go's builtin sub-tests and other utilities.
   
   Most of my comments are around the structure of those sub-tests, it took me a while to understand some of them, and how they're organized.
   
   But I think this is generally a great improvement, we should definitely get this in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org